Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance #11

Closed
3 tasks
nhooyr opened this issue Sep 9, 2018 · 6 comments
Closed
3 tasks

Performance #11

nhooyr opened this issue Sep 9, 2018 · 6 comments

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 9, 2018 •
edited
Loading

Need to make sure the API/lib is as simple as possible while not sacrificing any reasonable performance.

  • Consider struct padding
  • Pooling of buffers
  • Give gobwas/ws a through read
@nhooyr nhooyr added the p3 label Sep 9, 2018
@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 9, 2018

http://www.agardner.me/golang/garbage/collection/gc/escape/analysis/2015/10/18/go-escape-analysis.html

@nhooyr nhooyr removed the p3 label Mar 14, 2019
@nhooyr nhooyr changed the title Consider struct padding and any performance angle Optimize performance Mar 29, 2019
@nhooyr nhooyr changed the title Optimize performance Optimize Performance Mar 29, 2019
@nhooyr nhooyr changed the title Optimize Performance Optimize performance Mar 29, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 14, 2019

Related #54

I don't think I can do much here.

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 14, 2019 •
edited
Loading

Maybe an unsafe and fast version of masking? gobwas/ws and gorilla/websocket both do this.

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 15, 2019

See #54

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 19, 2019

Just need to open an issue regarding mask being optimized by the Go compiler by default.
Will also try to profile a little and see if there are any other issues here.

@nhooyr nhooyr changed the title Optimize performance Performance Apr 20, 2019
@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 21, 2019

See #64, #62 and #65

@nhooyr nhooyr closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhooyr