Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Update Code to 1.82 #6400

Closed
benz0li opened this issue Aug 28, 2023 · 11 comments · Fixed by #6436
Closed

[Feat]: Update Code to 1.82 #6400

benz0li opened this issue Aug 28, 2023 · 11 comments · Fixed by #6436
Labels
enhancement Some improvement that isn't a feature

Comments

@benz0li
Copy link
Contributor

benz0li commented Aug 28, 2023

What is your suggestion?

Update Code to 1.82

Why do you want this feature?

Update to Electron 25. See

Are there any workarounds to get this functionality today?

No.

Are you interested in submitting a PR for this?

Yes. But this needs to be planned for and supported by @code-asher.
ℹ️ That is why I am opening this issue right now.

@benz0li benz0li added the enhancement Some improvement that isn't a feature label Aug 28, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Sep 5, 2023

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 5, 2023

Also requesting this so we can use Cody inside code-server, which requires 1.79 or higher. See sourcegraph/cody#903

@benz0li
Copy link
Contributor Author

benz0li commented Sep 5, 2023

Also requesting this so we can use Cody inside code-server, which requires 1.79 or higher. See sourcegraph/cody#903

@jsjoeio The current version of code-server (4.16.1) is based on Code version 1.80.2.

Seems that https://dev.coder.com does not provide the current release, then.

@code-asher
Copy link
Member

@T-256
Copy link

T-256 commented Sep 7, 2023

As vscode added native support for local serving web, should it exists any document to tell the differences between code-server vs code serve-web?

@code-asher
Copy link
Member

code-asher commented Sep 7, 2023

I think the differences described here apply: https://github.com/coder/code-server/blob/main/docs/FAQ.md#whats-the-difference-between-code-server-and-github-codespaces

This specifically talks about the differences from Codespaces but most of it (the bullet points) still applies to running VS Code Web directly so I think we could add a new section here and move around some of the text.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 8, 2023

VS Code 1.82.0 was released yesterday: https://code.visualstudio.com/updates/v1_82

@benz0li benz0li changed the title [Feat]: Update Code to 1.82 (not released yet) [Feat]: Update Code to 1.82 Sep 8, 2023
@T-256
Copy link

T-256 commented Sep 8, 2023

I think we could add a new section here and move around some of the text.

Correct, and by that, people will know the reasons why they should prefer code-server above native server.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 12, 2023

VS Code 1.82.1 was released today: https://code.visualstudio.com/updates/v1_82

@code-asher I will take a look at it on Thursday.

@benz0li
Copy link
Contributor Author

benz0li commented Sep 16, 2023

VS Code 1.82.2 was released yesterday: https://code.visualstudio.com/updates/v1_82

I have just been tasked with troubleshooting an HA cluster.

@code-asher You are on your own.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 16, 2023

Also requesting this so we can use Cody inside code-server, which requires 1.79 or higher. See sourcegraph/cody#903

@jsjoeio The current version of code-server (4.16.1) is based on Code version 1.80.2.

Seems that https://dev.coder.com does not provide the current release, then.

oh wow lol you can tell it's been that long that I didn't even think to check that 🤦‍♂️ thank for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants