-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lando commands fail silently when run from a code-server terminal #3306
Comments
Okay here are the steps I took to reproduce using macOS + Chrome:
Now, with code-server:
Actually...none of the Lando commands are working 🤔 That's very strange. Lando DocsLooking a bit further into this, I see these two messages:
I don't think that's related but adding here just in case. Source: Lando CLI docs Hard to tell if this is specific to code-server or Lando. Let's see if @code-asher or @oxy has any input. |
@jsjoeio thank you for taking the time to reproduce. It seems strange that Lando commands wouldn’t work in code server but I don’t know enough about the internals to know why. |
Thanks for leaving such clear instructions! It is very strange. I would think it would at least log an error or something. I'm really unsure of what could be happening. Hopefully the others have an idea. |
I've added a bug report in the Lando repo to cross reference this issue: lando/lando#3000 |
Thanks for the instructions! I just attempted to reproduce it on my Linux build, and it works perfectly fine on both 3.9.3 and on |
Thanks for testing! Interesting... I'm doing this in a Linux environment, using WSL2, so I don't think it's MacOS specific. I'll see if I can test (what will be) 3.10.0 version |
That's curious - another thing that differed for me was that I was using lando from git instead of the Does using lando from git instead of a release change anything? |
Ah yes, running the version from git works! Steps:
|
That's interesting - looking at commit logs nothing really changed after |
Yes I don't think it's lando code itself... I'm just trying different tags to see if any don't work. I suspect its something about the way its packaged and installed but no idea why that would be an issue at this point. Confirmed, running off different tags from the source (and doing a yarn install to be sure) doesn't seem to make any difference, the tagged version is correctly displayed in code-server's terminal. |
I've updated the issue on the Lando side, lets see what the maintainers think over there. A very curious issue! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days. |
OS/Web Information
code-server --version
:3.9.3 fe2dc2deb08e378069891b622bb62ad1d261d1b1
Problem description
For reasons I don't understand, a single specific terminal command won't run (silently fails) when executed under code-server's terminal. This does not happen in the 'normal' terminal and does not happen in VS Code's terminal. They are all using exactly the same system (confirmed but entering a command in one, then cycling back through the history in another and confirmed the same commands are executed).
Steps to Reproduce
lando version
in any terminal (except the terminal of code server) and confirm there is outputlando version
in the terminal and confirm there is no outputExpected
Terminal should output:
Actual
There is no output after running the command:
An exit code of
4
is shown if$?
is entered afterwardsLogs
I ran:
code-server --log debug
and entered the command in the terminal.
logs.zip
Screenshot
lando version
in the WSL2 terminal:lando version
in the code-server terminal:Notes
This issue can be reproduced in VS Code: No, the issue does not happen in VS Code.
The text was updated successfully, but these errors were encountered: