Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is something wrong with ViewTest::testRenderScrapsDataByDefault #846

Closed
vinodselvin opened this issue Nov 27, 2017 · 2 comments
Closed

There is something wrong with ViewTest::testRenderScrapsDataByDefault #846

vinodselvin opened this issue Nov 27, 2017 · 2 comments

Comments

@vinodselvin
Copy link
Contributor

ViewTest::testRenderScrapsDataByDefault

asserts
$this->assertTrue(empty($view->getData()));

it has be not empty

$this->assertTrue(!empty($view->getData()));
@lonnieezell
Copy link
Member

Yup. Am aware. That's because I changed the default way that acts and forgot to change the test. Will get to it soon :)

@vinodselvin
Copy link
Contributor Author

vinodselvin commented Nov 27, 2017 •
edited
Loading

I guess due to that all my pull requests were failing, see here #845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lonnieezell @vinodselvin