New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why IncomingRequest has setCookie()? #52

Closed

kenjis opened this issue Apr 1, 2016 · 2 comments

Member

kenjis commented Apr 1, 2016

https://github.com/lonnieezell/CodeIgniter4/blob/develop/system/HTTP/IncomingRequest.php#L307
It sets a cookie to a response, doesn't it?

Member

lonnieezell commented Apr 2, 2016

You're right. It does belong in the response. I'm sure it got left there simply because it was in the Input class in CI3.

Member Author

kenjis commented Apr 2, 2016

Okay, I hope the Response class has cookie data.
So that we can test cookie data like: https://github.com/kenjis/ci-phpunit-test/blob/master/docs/FunctionAndClassReference.md#testcaseassertresponsecookiename-value-allow_duplicate--false

lonnieezell closed this as completed in

1e2df74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment