Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat all CI environment as Testing environment. #4804

Closed
vibbow opened this issue Jun 9, 2021 · 1 comment
Closed

Don't treat all CI environment as Testing environment. #4804

vibbow opened this issue Jun 9, 2021 · 1 comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@vibbow
Copy link
Contributor

vibbow commented Jun 9, 2021

We are using Jenkins to do out production deploy, after file copying, jenkins will call CodeIgniter's spark to do some init jobs.

Since Jenkins 2.286, Jenkins changed it's behaviour, added CI=true environment variable.
https://issues.jenkins.io/browse/JENKINS-36707
This change merged into Jenkins LTS 2.289.1 since 2021-06-02

This breaks our deployment config, since CodeIgniter will tread Jenkins as Testing environment.

We had modify spark to force specific the environment as production as temp solution.

But is there a better way to archive it: using Jenkins to do deployment, and not tread Jenkins as Testing environment.

@vibbow vibbow added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 9, 2021
@paulbalandan paulbalandan changed the title Not tread all CI environment as Testing environment. Don't treat all CI environment as Testing environment. Jun 9, 2021
@paulbalandan
Copy link
Member

What CI version are you using? As of v4.1.2, this has been resolved by #4692 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

2 participants