Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: stringify_attributes() looks unfinished. #3363

Closed
ivantcholakov opened this issue Jul 19, 2020 · 3 comments
Closed

Bug: stringify_attributes() looks unfinished. #3363

ivantcholakov opened this issue Jul 19, 2020 · 3 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@ivantcholakov
Copy link

https://github.com/codeigniter4/CodeIgniter4/blob/v4.0.4/system/Common.php#L1007

The comment about stringify_attributes() says that the first parameter may be a string, an array and an object type. But I don't see code to handle the object type case, for example a type check and get_object_vars() call.

@ivantcholakov ivantcholakov added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 19, 2020
@ivantcholakov
Copy link
Author

Or something like this: https://gist.github.com/ericlbarnes/3195974

@paulbalandan
Copy link
Member

Line 1034 is the answer you are looking for.

@ivantcholakov
Copy link
Author

Ah, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

2 participants