Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint message in tutorial does not correspond to the example code shown #3242

Closed
Connum opened this issue Jul 7, 2020 · 1 comment
Closed
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@Connum
Copy link
Contributor

Connum commented Jul 7, 2020

Documentation URL:
https://codeigniter4.github.io/userguide/tutorial/news_section.html

Description:
At the end of the section Display the news, there's a note with the following message:

We are again using using esc() to help prevent XSS attacks. But this time we also passed “url” as a second parameter. That’s because attack patterns are different depending on the context in which the output is used. You can read more about it here.

However, there is no "url" parameter in the code example above that note:

<h2><?= esc($news['title']); ?></h2>
<?= esc($news['body']); ?>

So, either the parameter is missing, or the note is superfluous here.

@Connum Connum added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 7, 2020
@jreklund
Copy link
Contributor

jreklund commented Jul 8, 2020

Hi, this are a duplicate of #2960 and have been fixed in the development branch. I placed it on the wrong code block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

3 participants