Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Not bug, but Fix Documentation, please #2920

Closed
njsx opened this issue May 2, 2020 · 2 comments
Closed

Bug: Not bug, but Fix Documentation, please #2920

njsx opened this issue May 2, 2020 · 2 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@njsx
Copy link

njsx commented May 2, 2020

In the validation section:

less_than -> Fails if field is greater than or equal to the parameter value or not numeric.
less_than_equal_to -> Fails if field is greater than the parameter value or not numeric.

must be reverse!

@njsx njsx added the bug Verified issues on the current code behavior or pull requests that will fix them label May 2, 2020
@paulbalandan
Copy link
Member

Not a doc error. I think you are confused.

Let us say you have a param value of 5 and test values of 5 and 6:

// not the official syntax though
// TESTVAL OPERATOR[PARAMVAL]
5 less_than[5] // false
6 less_than[5] // false
5 less_than_equal_to[5] // true
6 less_than_equal_to[5] // false

@michalsn
Copy link
Member

As @paulbalandan pointed out - documentation is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

3 participants