Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time testing in travis-ci wonky #1229

Closed
jim-parry opened this issue Sep 21, 2018 · 2 comments
Closed

Time testing in travis-ci wonky #1229

jim-parry opened this issue Sep 21, 2018 · 2 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them testing Pull requests that changes tests only

Comments

@jim-parry
Copy link
Contributor

Travis-ci continues to break intermittently, because one of the tests can be out by 1 second. The error has nothing to do with any changes made in a PR.

CodeIgniter 4 version
develop

Error message

  1. CodeIgniter\I18n\TimeTest::testTimeWithDateTimeZone
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'2018-09-21 19:56:07'
    +'2018-09-21 19:56:08'
    /home/travis/build/bcit-ci/CodeIgniter4/tests/system/I18n/TimeTest.php:76
@jim-parry jim-parry added bug Verified issues on the current code behavior or pull requests that will fix them testing Pull requests that changes tests only labels Sep 21, 2018
@jim-parry jim-parry added this to the Alpha milestone Sep 21, 2018
@puschie286
Copy link
Contributor

we can reduce the frequency of it occurring by creating the control time right at the beginning

@jim-parry jim-parry mentioned this issue Sep 30, 2018
Merged
@jim-parry
Copy link
Contributor Author

I'm going to call this one done - I don't see any recurrences of the timing hiccups.
To boot, we now know how to fix them :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puschie286 @jim-parry