Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use both hostname and ip address for debug service certificate #1666

Closed
william-xiang opened this issue Nov 19, 2023 · 2 comments
Closed

Use both hostname and ip address for debug service certificate #1666

william-xiang opened this issue Nov 19, 2023 · 2 comments
Milestone

Comments

@william-xiang
Copy link
Contributor

Currently the generated debug service certificate only uses the host value specified by the user, either hostname or ip address. And in the certificate this value is used as the common name. This means if this value is the hostname, then other user cannot use ip address to connect that machine and do debugging. Otherwise, the debug session will fail with this error:
image

The certificate should contain both the hostname and ip address as the subject alternative names. So users can use either hostname or ip address for connection.

@worksofliam worksofliam added this to the 3.0.0 milestone Nov 19, 2023
@worksofliam
Copy link
Contributor

@william-xiang is this solved by #1667?

@william-xiang
Copy link
Contributor Author

@william-xiang is this solved by #1667?

@worksofliam yes, this issue is resolved by that PR. Issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants