From 1ed0d28b475f20dccb10ecd5e417be7579ceaed5 Mon Sep 17 00:00:00 2001 From: Melanie Date: Tue, 28 Jan 2025 09:31:56 -0500 Subject: [PATCH] PR comments and cleanup --- app/helpers/state_file/nj_2450_helper.rb | 2 +- .../submission_builder/ty2024/states/nj/documents/nj2450.rb | 2 -- .../ty2024/states/nj/documents/nj2450_spec.rb | 6 ++---- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/app/helpers/state_file/nj_2450_helper.rb b/app/helpers/state_file/nj_2450_helper.rb index 31171c1145..c5511aa214 100644 --- a/app/helpers/state_file/nj_2450_helper.rb +++ b/app/helpers/state_file/nj_2450_helper.rb @@ -19,7 +19,7 @@ def get_wages(w2) end def get_column_a(w2) - column_a = w2.box14_ui_wf_swf&.positive? ? w2.box14_ui_wf_swf : w2.box14_ui_hc_wd + column_a = w2.get_box14_ui_overwrite || 0 column_a&.round || 0 end diff --git a/app/lib/submission_builder/ty2024/states/nj/documents/nj2450.rb b/app/lib/submission_builder/ty2024/states/nj/documents/nj2450.rb index f9339f765f..5b3c439028 100644 --- a/app/lib/submission_builder/ty2024/states/nj/documents/nj2450.rb +++ b/app/lib/submission_builder/ty2024/states/nj/documents/nj2450.rb @@ -19,8 +19,6 @@ def document build_xml_doc("FormNJ2450") do |xml| w2s.each do |w2| xml.Body do - column_a = w2.box14_ui_wf_swf&.positive? ? w2.box14_ui_wf_swf : w2.box14_ui_hc_wd - xml.EmployerName get_employer_name(w2, truncate: true) xml.FedEmployerId w2.employer_ein xml.Wages get_wages(w2) diff --git a/spec/lib/submission_builder/ty2024/states/nj/documents/nj2450_spec.rb b/spec/lib/submission_builder/ty2024/states/nj/documents/nj2450_spec.rb index f1baadc7e1..c7ab6a1da8 100644 --- a/spec/lib/submission_builder/ty2024/states/nj/documents/nj2450_spec.rb +++ b/spec/lib/submission_builder/ty2024/states/nj/documents/nj2450_spec.rb @@ -21,14 +21,12 @@ it "fills body for each w2" do body_elements = xml.css("Body") expect(body_elements.count).to eq 2 + w2_long_employer_name = body_elements[0] + expect(w2_long_employer_name.at('EmployerName').text.length).to eq(35) body_elements.each do |body| w2 = [w2_1, w2_2].find { |test_w2| test_w2.employer_ein == body.at('FedEmployerId').text} - expect(body.at('EmployerName').text).to eq(w2.employer_name[0...35]) - if w2.employer_name == long_employer_name - expect(body.at('EmployerName').text.length).to eq(35) - end expect(body.at('Wages').text).to eq(w2.wages.round.to_s) expect(body.at('Deductions ColumnA').text).to eq(w2.box14_ui_hc_wd.round.to_s) expect(body.at('Deductions ColumnC').text).to eq(w2.box14_fli.round.to_s)