Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locale and time zone to be configured in settings.yml #322

Open
pmackay opened this issue Apr 20, 2015 · 2 comments
Open

Allow locale and time zone to be configured in settings.yml #322

pmackay opened this issue Apr 20, 2015 · 2 comments

Comments

@pmackay
Copy link
Contributor

pmackay commented Apr 20, 2015

Could these values defined in application.rb be defined in settings.yml instead?

I could do a PR.

BTW, I'm assuming its ok to raise feature request issues and then do a PR?

@monfresh
Copy link
Member

Yes, and yes, but since this is a feature request, please reword the issue title so that it reads like a request or a question, such as Allow locale and time zone to be configured in settings.yml. Otherwise, it sounds like locale and time zone can already be configured in settings.yml, and that the fact that they can be configured there is a bug.

@pmackay pmackay changed the title Locale and time zone can be configured in settings.yml Allow locale and time zone to be configured in settings.yml Apr 21, 2015
@pmackay
Copy link
Contributor Author

pmackay commented Apr 21, 2015

Sure. I tend to name issues for features/stories as if they describe the desired state, as it were. Noted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants