Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom text not working in demo #133

Open
rowanbradley opened this issue Oct 9, 2017 · 1 comment
Open

Custom text not working in demo #133

rowanbradley opened this issue Oct 9, 2017 · 1 comment

Comments

@rowanbradley
Copy link

I have copied your demo page lock stock and barrel onto my site. None of the examples in your demo file are displaying the custom message. The warning box always says:
Do you want to leave this site?
Changes that you made may not be saved.
Prevent this page from creating additional dialogues.
[Leave|Stay]
I haven't made any changes to your code (other than to change the location of the JS files to match my site, and to use the latest version of JQuery).

Another small issue. Why is it correct to say "Changes that you made MAY not be saved". Under what circumstances would they have been saved? I thought the point of this code was only to put up the alert if the user HAD made changes, and HAD NOT saved them. In which case why isn't it more accurate to say "Your changes HAVE NOT been saved"?

Thanks - Rowan

@pawamoy
Copy link

pawamoy commented Oct 17, 2017

Same here, tried to customize message with

$(function() {
  $('#question-form').areYouSure({
    'message': 'If you leave before saving, your changes will be lost.'
  });
});

But the alert box shows the default message which is This page is asking you to confirm that you want to leave - data you have entered may not be saved.

Edit: I'm on Firefox 56. I see in another issue that Chrome does not allow changing the sentence, maybe it's the same for Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants