Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Commit status check missing when action is triggered by pull_request event #95

Closed
sfdye opened this issue Jul 16, 2020 · 7 comments
Assignees

Comments

@sfdye
Copy link

sfdye commented Jul 16, 2020

We noticed the commit status check started to disappear once we migrate from Travis CI to Github Action (using this action for uploading coverage to codecov)

Further debugging reveals that with

on:
  push:
    branches: master
  pull_request:

there is no status check.

However if the event trigger is push

on:
  push:
  pull_request:

the status check is back.

@thomasrockhu
Copy link
Contributor

@sfdye could you provide a link to the builds?

@thomasrockhu thomasrockhu self-assigned this Jul 29, 2020
@sfdye
Copy link
Author

sfdye commented Jul 29, 2020

It's a private repo. What exactly from the log are trying to check? I can crop it here

@thomasrockhu
Copy link
Contributor

I'd love to start with a recent commit SHA (in the past 5 days) of this happening if possible.

@thomasrockhu
Copy link
Contributor

Alternatively, @sfdye please open a ticket in our community boards and we can switch to DM if necessary.

@sfdye
Copy link
Author

sfdye commented Jul 29, 2020

Sound good, let me port this issue over

@sfdye sfdye closed this as completed Jul 29, 2020
@sfdye
Copy link
Author

sfdye commented Jul 29, 2020

@Licenser
Copy link

We're having the same issue in a public repository - here is a visible example: tremor-rs/tremor-runtime#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants