Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 shows only Python coverage and omits C coverage #566

Closed
hugovk opened this issue Oct 19, 2021 · 1 comment
Closed

v2 shows only Python coverage and omits C coverage #566

hugovk opened this issue Oct 19, 2021 · 1 comment

Comments

@hugovk
Copy link

hugovk commented Oct 19, 2021

Testing switching use of v1 of the action and the bash uploader to v2 of the action means C code which was previously reported is now omitted.

For example, using the action like this (varying the flags/name per OS):

    - name: Upload coverage
      uses: codecov/codecov-action@v2
      with:
        file: ./coverage.xml
        flags: ${{ matrix.codecov-flag }}
        name: ${{ matrix.os }} Python ${{ matrix.python-version }}

Here's a branch using v1 and the bash uploader, report includes both Python and C code (C code in src and src/libImaging dirs):

Here's a branch switching to v2 for both, but report includes only Python code:

There's a bit of variation between OS, but we're generally building like this:

CFLAGS="-coverage -Werror=implicit-function-declaration" python3 setup.py build_ext install

And testing with pytest and pytest-cov and generating coverage.xml with either the --cov-report xml switch or coverage xml command.

Am I missing something?

@thomasrockhu-codecov
Copy link
Contributor

@hugovk if this is still an issue, please open a topic on our community boards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants