Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Using gcov argument results in warning #1247

Closed
jwillemsen opened this issue Feb 1, 2024 · 6 comments
Closed

[v4] Using gcov argument results in warning #1247

jwillemsen opened this issue Feb 1, 2024 · 6 comments
Assignees

Comments

@jwillemsen
Copy link

I am using the gcov optional argument as described at https://github.com/codecov/codecov-action#arguments but that results in the warning below

2024-02-01T10:36:53.0226212Z ##[warning]Unexpected input(s) 'gcov', valid inputs are ['token', 'file', 'files', 'commit_parent', 'directory', 'dry_run', 'env_vars', 'exclude', 'fail_ci_if_error', 'flags', 'name', 'os', 'override_branch', 'override_build', 'override_commit', 'override_pr', 'plugin', 'plugins', 'root_dir', 'slug', 'url', 'verbose', 'version', 'working-directory']
2024-02-01T10:36:53.0238741Z ##[group]Run codecov/codecov-action@v4

codecov4warning.txt

@jwillemsen
Copy link
Author

Upgrade PR RemedyIT/taox11#356

@jwillemsen
Copy link
Author

Github action step

    - uses: codecov/codecov-action@v4
      with:
        gcov: true
        fail_ci_if_error: true 
        verbose: true # optional (default = false)
      env:
        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Feb 1, 2024
@radarhere
Copy link

After these comments were made, @thomasrockhu-codecov removed the 'gcov' argument from the README, and instead added

plugin | plugins to run. Options: xcode, gcov, pycoverage. The default behavior runs them all.

So is the solution to this to simply remove 'gcov: true', and rely on the default behaviour to run gcov?

@thomasrockhu-codecov
Copy link
Contributor

@radarhere I'm sorry, I had meant to come back to this and reply, but I got caught in a few other things first.

Yes, the arguments in the README were outdated for v4. It was this issue that led me to that, so thank you. You should not need the gcov argument any longer. If I am mistaken and you run into issues, please let me know.

@thomasrockhu-codecov
Copy link
Contributor

@jwillemsen the same should be true for you as well.

@jwillemsen
Copy link
Author

Works without gcov now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants