-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keycloakx] KeycloakX support [DRAFT] #533
[keycloakx] KeycloakX support [DRAFT] #533
Conversation
e1d062c
to
0439b83
Compare
Wanted to leave some positive feedback, we now use this version of the chart for deployment. Thanks! |
# The Service port at which metrics are served | ||
port: http | ||
|
||
extraServiceMonitor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to remove or extend the extraServiceMonitor
option? The common use case seems to be to monitor the /auth/realms/master/metrics
endpoint, but would we not want to support more than one realm metrics endpoint? At the moment only a single additional endpoint is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well there are /auth/metrics
for global metrics and /auth/realms/foo/metrics
with potentially realm specific metrics.
Of course the latter depends on the metrics extension used.
I also just noticed that we should make the /auth
path option (--http-relative-path
or KC_HTTP_RELATIVE_PATH
) configurable which also defines the prefix for /metrics
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, maybe we should also not change too much here to not break too much compatibility with the old Keycloak helm chart. Just as reference: The original issue requesting the extraServiceMonitor
option seems to be this one: #309
51faa05
to
7f0740f
Compare
e071265
to
824f53b
Compare
4394582
to
e6925e3
Compare
- Created new chart based on wildfly based Keycloak chart - Change podManagementPolicy to OrderedReady Using Parallel in conjunction with Infinispan causes some problems during startup and there is a brief period of time where the infinispan nodes are out of sync. - Reduce initialDelaySeconds for probes to make keycloak available faster - Allow longer dns names for keycloakx - Add support for custom console domain names See codecentric#549 - Use Keycloak.X 17.0.1 - Review readme Remove wildfly references Adapt high availability chapter Adapt env variable description - Remove references to wildfly Remove unused port 9990 Remove unused variable highAvailability Remove wildfly reference in servicemonitor configuration - Simplify ingress definition Removed support for older ingress versions - Update metrics support Update metrics path documentation Add KC_METRICS_ENABLED=true if metrics.enabled=true - Replace postgres specific configuration with generic database configuration Revise configuration options of Keycloak.X chart - Ease configuration with sane defaults - Add usage examples Fixes codecentric#544 Co-authored-by: Philip Sanetra <code@psanetra.de> Signed-off-by: Philip Sanetra <code@psanetra.de> Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
e6925e3
to
caa34e5
Compare
A revised chart for Keycloak.X