Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keycloakx] KeycloakX support [DRAFT] #533

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

thomasdarimont
Copy link
Contributor

@thomasdarimont thomasdarimont commented Jan 28, 2022

A revised chart for Keycloak.X

@thomasdarimont thomasdarimont changed the title PoC for KeycloakX support [keycloak ]PoC for KeycloakX support [DRAFT] Jan 28, 2022
@thomasdarimont thomasdarimont changed the title [keycloak ]PoC for KeycloakX support [DRAFT] [keycloakx] PoC for KeycloakX support [DRAFT] Jan 28, 2022
@Morl99
Copy link

Morl99 commented Mar 15, 2022

Wanted to leave some positive feedback, we now use this version of the chart for deployment. Thanks!

# The Service port at which metrics are served
port: http

extraServiceMonitor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to remove or extend the extraServiceMonitor option? The common use case seems to be to monitor the /auth/realms/master/metrics endpoint, but would we not want to support more than one realm metrics endpoint? At the moment only a single additional endpoint is supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well there are /auth/metrics for global metrics and /auth/realms/foo/metrics with potentially realm specific metrics.
Of course the latter depends on the metrics extension used.

I also just noticed that we should make the /auth path option (--http-relative-path or KC_HTTP_RELATIVE_PATH) configurable which also defines the prefix for /metrics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, maybe we should also not change too much here to not break too much compatibility with the old Keycloak helm chart. Just as reference: The original issue requesting the extraServiceMonitor option seems to be this one: #309

@thomasdarimont thomasdarimont force-pushed the poc/keycloakx branch 3 times, most recently from 51faa05 to 7f0740f Compare March 22, 2022 23:16
@thomasdarimont thomasdarimont changed the title [keycloakx] PoC for KeycloakX support [DRAFT] [keycloakx] KeycloakX support [DRAFT] Apr 7, 2022
- Created new chart based on wildfly based Keycloak chart
- Change podManagementPolicy to OrderedReady
Using Parallel in conjunction with Infinispan causes some problems
during startup and there is a brief period of time where the
infinispan nodes are out of sync.
- Reduce initialDelaySeconds for probes to make keycloak available faster
- Allow longer dns names for keycloakx
- Add support for custom console domain names
See codecentric#549
- Use Keycloak.X 17.0.1
- Review readme
Remove wildfly references
Adapt high availability chapter
Adapt env variable description
- Remove references to wildfly
Remove unused port 9990
Remove unused variable highAvailability
Remove wildfly reference in servicemonitor configuration
- Simplify ingress definition
Removed support for older ingress versions
- Update metrics support
Update metrics path documentation
Add KC_METRICS_ENABLED=true if metrics.enabled=true
- Replace postgres specific configuration with generic database configuration
Revise configuration options of Keycloak.X chart
- Ease configuration with sane defaults
- Add usage examples

Fixes codecentric#544

Co-authored-by: Philip Sanetra <code@psanetra.de>

Signed-off-by: Philip Sanetra <code@psanetra.de>
Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
@thomasdarimont thomasdarimont merged commit 31f44ca into codecentric:master Apr 8, 2022
@thomasdarimont thomasdarimont deleted the poc/keycloakx branch April 8, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants