Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for December Elections #309

Merged
merged 48 commits into from
Nov 30, 2020
Merged

Updates for December Elections #309

merged 48 commits into from
Nov 30, 2020

Conversation

aniri
Copy link
Member

@aniri aniri commented Nov 30, 2020

No description provided.

@vercel
Copy link

vercel bot commented Nov 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/monitorizare-vot-ong/c18h2ah8h
✅ Preview: https://monitorizare-vot-ong-c18h2ah8h.vercel.app

bvizureanu and others added 27 commits November 30, 2020 12:05
* Add loader for download answers action #257

* Feature: answer.component.html download button disabled if data is loading
In `--sourcemap` is not a valid flag anymore, see `--sourceMap` https://angular.io/cli/build
* Move frontend to root. Remove testing libraries.

* Remove dummy spec files

* Remove unused dependencies

* Update bootsrap. Change angular and tsconfig so that it reflects the latest angular version

* Update azure pipeline

* Move frontend to root. Remove testing libraries.

* Remove dummy spec files

* Remove unused dependencies

* Update bootsrap. Change angular and tsconfig so that it reflects the latest angular version

* Update azure pipeline

* Resolve checkbox and tabs problem.

* Resolve tabs problem

* Resolve azure pipeline

* Add loading to download button

Co-authored-by: Irina Borozan <anirib@gmail.com>
* Resolve some design problems

* More design fixes. Remove all unused imports

* Try to rollback old design with the new bootstrap
* feat: add confirmation shared model for delete confirmation

* feat: add delete modal for forms

* refactor: cleanup#1

* feat: remove: modal spec file
ajeurkar and others added 21 commits November 30, 2020 12:09
Signed-off-by: Ajinkya Jeurkar <ajeurkar@proximabiz.com>
* Updated form UI

* Missed the name change

* Updated comments in PR, Fixed Translations and added Description Textarea
* refers to #275

Co-authored-by: Irina Borozan <anirib@gmail.com>
* Updated login to new UI

* translations added

* larger image added
* updated form spacing and mobile

* fixed spacing
* Implemented DELETE /api/v1/observer endpoint in observers list.

* Added localized strings for observer delete dialog.

* Added localized strings for previously implemented observer delete dialog.
* 1 line on cards

* removed the dash
* AnswerFilter mdl rm observerId add observerPhone

Added phoneObserver param to srvc

Filter by observerPhone instead of observerId

* added translations

* add observer phone number filter

Co-authored-by: Irina Borozan <anirib@gmail.com>
* chore(observers ): adjust header title according to the design

* feat(answers): add `answers` module

* i18n(answers): add translations for table columns

* feat(answers): add the `download` functionality to the export button

* feat(answers): add filters according to the design

* refactor(table-container): extract types & interfaces into a separate file

* feat(table-container): allow to use custom `no-rows-found` content

* feat(answers): add `no-rows-found` message

* feat(table-container): allow rows to be clicked

* feat(answers): add `answer-detail` component

* allows to view an answer in detail

* feat(answers): add `answer-details` component

* wip(answer-details): build the base for the forms container

* chore(scss): add global variables for gray common colors

* border-color-gray / dim-gray

* fix(answers): remove unwanted `answer-detail` component

* feat(base-checkbox): add transparent variant

* feat(answer-details): display sections, their forms, alongside checked/unchecked answers

* fix(visually-hidden): remove absolute position

* by using `position: absolute`, in Chrome(and Brave as well) we get a weird error: looks like although the content that overflows is hidden by the `sections container`, the scroll bar behaves as if it wouldn't overflow
* in Firefox we don't have this error

* feat(answer-details): show question's note

* fix(answers): fetch answers without previous `state.urgent` value

* fix(header): make hambuger menu contain all of its items

* feat(answers): add `CanLoad` guard to `answers` module

* feat(answer-notification): add page for sending notifications

* feat(base-button): allow to have inheritet color

* particularly useful when we want the button's color to depend on the class applied on the `container`

* fix(answer-details): change `View Note` button's color in accordance with the question's flagged status

* i18n(answers/*): add translations

* fix(answers): show total number of all records

* instead of the number of current records shown in page

* feat(table): identify a table column by using a custom directive

* feat(answers): make `filters` work

* feat(answers): reset filters

* as a result, the entries will be shown accordingly

* feat(county): add `county` store slice

* feat(answers): select `counties` filter from `select` tag

* feat(answers): show `Location Type` & `Date&Time` columns in table

* feat(answer-details): show `Location Type` & `Date&Time` stats

* refactor(answers): remove `from` & `to` filters

* feat(base-checkbox): allow checkbox to be readonly(disabled)

* feat(answer-details): make every answer readonly

* fix(observers): allow the `table` comp to query the tableColumn properly

* fix(answers.effects): avoid calling for extra details when initial response is empty

* feat(answers/form): fetch forms when only needed

* feat(answers): fetch data only when needed & don't refetch redundantly

* feat(answers-notification): send notification

* feat(notes): fetch data only when needed & don't refetch redundantly

* refactor: replace `/urgents` route with `urgent` filter in `/answers`

* feat(answer-questions): display questions & answers in separate component

* feat(answer-details): add `Notes` tab

* feat(answer-details): add `Notes` tab

* feat(answer-details): scroll to question from `Notes` tab

* feat(answer-details): open modals with content decided by child components

* feat(notes): open modal with note on row click

* refactor(notes): let the `answer-details` hold the template with the modal content

* reason: both `notes` and `answer-questions` are bound to use the same modal template

* feat(answer-questions): show note in modal when the `View Note` is called

* feat(notes): display shrunk note text with ellipsis when necessaryy

* feat(answer-questions): improve highlight of flagged question

* fix: make `visually-hidden` class work on both Chrome and Firefox

* fix(answer-questions): remove empty spaces from `textarea`

* feat(answers): make layout responsive

* fix(notes): fetch notes immediately as `answer-details` is rendered

* this is to show the questions with notes from the crt tab properly

* feat(answers): add loading icon

* feat(answer-details): add loading icon

* fix(login): redirect to `/answers` instead of the old `/urgents`

* feat: reset state after logout

* fix(answers): make `Export` button work

* fix(answer-details): scroll to question from a tab different than the previous one visited

* when, from `Notes` tabm the user is redirected to a form tab which is different than the previous one, shown exactly before the user had visited the `Notes` tab

* i18n(answer-details): add translations

* feat(answer-notification): show message after notification has been sent

* refactor(notes): display '-' when a question link is missing
* 210 - Started notification page adjustments

* 210 - Optimize imports

* 210 - Finalized UI refactor

* 210 - Added min/max pollingStation number

* 210 - Fixed scenario of empty filter; translated validation message

* 210 - Fix remove county scenario to clear the filter

* Update en.json

Co-authored-by: Irina Borozan <anirib@gmail.com>
* 210 - Started notification page adjustments

* 210 - Optimize imports

* 210 - Finalized UI refactor

* 210 - Added min/max pollingStation number

* 210 - Fixed scenario of empty filter; translated validation message

* 210 - Fix remove county scenario to clear the filter

* 218 - Initial commit (empty table)

* 218 - Fixed table data

* 218 - Added notification history back button; aligned translations

* 218 - Fix merge issues

* 218 - Fix merge issues 2

* 218 - Fixed missing directive in notification-history.component.html

* 218 - Reverted changes outside scope; reduced notification history table size
* AnswerFilter mdl rm observerId add observerPhone

Added phoneObserver param to srvc

Filter by observerPhone instead of observerId

* form list updated to new ui

* Removed package-lock.json

* Added package-lock.json to gitignore

* Added some translations.

* Made the template look more similar to the mock-up.

Also disabled columns that are yet to be implemented.

* Added publish/unpublish button to dropdown in 'Forms' list.

* Re-commented a piece of code which was un-commented for some unknown reason.

* Merged two methods into one as there was no reason to have them both.

* Fixed a bug where the app would crash if there were no drafts returned.

* Reverted a change in formDelete action

* Removed accidental duplicate key in ro.json

Co-authored-by: Robert Kovacs <kovrobert@yahoo.com>
* 210 - Started notification page adjustments

* 210 - Optimize imports

* 210 - Finalized UI refactor

* 210 - Added min/max pollingStation number

* 210 - Fixed scenario of empty filter; translated validation message

* 210 - Fix remove county scenario to clear the filter

* 218 - Initial commit (empty table)

* 218 - Fixed table data

* 218 - Added notification history back button; aligned translations

* 218 - Fix merge issues

* 218 - Fix merge issues 2

* 218 - Fixed missing directive in notification-history.component.html

* 227 - Progress focused notification

* 218 - Reverted changes outside scope; reduced notification history table size

* 227 - Send notifications from observers table
* updated texts

* change file extension for export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.