-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension Instant Search & Completition #1171
Comments
👍 @hboyd2003 |
@ImprovedTube I see the problem now, thanks for updating the report. It looks like this is an issue with @victor-savinov's Satus library. The version in the ImprovedTube repo is minified so its missing all the readable variable names which makes it hard to understand. @victor-savinov Doesn't have the none-minified version uploaded anywhere so I can't really fix it. In the future it would be better to have the un-minified version in the repo and just have the minification built into the build script for quicker development. |
@ImprovedTube Also I don't think there exists a bug that is not already an existing feature, so no real use to adding the feature exists label to bugs it should be used for feature requests where the feature exists in another form (such as a feature that exists in another extension) |
Exactly! Firefox also requires source / unminified. i dont recall adding feature exists :D |
1. Our search in the extension:
To implement more functional search, the least we got to cover is Synonyms/Tags & language/s (english + and the user's language, and secondary langauges set in the browser) STRUCTURE: Tooltips; extra Tags/keywords; Menu sections; Search; Documentation [PLEASE BRAINSTORM] #748 )
Possibly with a 3rd party JS/indexDB search lib. While "overpowered here, it wont harm & we should learn the most performant one anyways for History Manager https://github.com/code-for-charity/History-Manager-with-indexedDB (instead of reinventing this wheel) ( inspiration: https://github.com/nextapps-de/bulksearch - or the most actively developed one today....) (please test History manager!)
2. bugs since v4.0:
bug: doesnt find any string with spaces..
instant search is missing (=focus on the input)
( why? @victor-savinov )bug in satus.js with marking text in all
inputstext areas (ctrl+a)bugs, which always happened:
The text was updated successfully, but these errors were encountered: