Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Instant Search & Completition #1171

Open
2 of 7 tasks
ImprovedTube opened this issue Dec 28, 2021 · 4 comments
Open
2 of 7 tasks

Extension Instant Search & Completition #1171

ImprovedTube opened this issue Dec 28, 2021 · 4 comments
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Completion / Revision Rethink, complete, improve, tweak our feature or structure. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) UI (UX) about our UI (UX) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Dec 28, 2021

1. Our search in the extension:

2. bugs since v4.0:

bugs, which always happened:

  • Not focused to react to keys when going back to home screen - (refers to version: https://github.com/code-for-charity/YouTube-Extension/releases/tag/v3.900 )
    • of course it can also listen to keyboard input in our folders / sections (except when setting hotkeys). Only difference in search results then can be to show each folder's results on top, before other results. (in general the section names could just be for the sorting order)
@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Dec 28, 2021
@hboyd2003 hboyd2003 added No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?) and removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Sep 29, 2022
@ImprovedTube ImprovedTube added UI (UX) about our UI (UX) and removed No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?) labels Sep 29, 2022
@ImprovedTube ImprovedTube changed the title Instant Search Extension Instant Search Sep 29, 2022
@ImprovedTube ImprovedTube changed the title Extension Instant Search 3 Extension Instant Search Bugs Sep 29, 2022
@ImprovedTube ImprovedTube changed the title 3 Extension Instant Search Bugs Extension Instant Search Bugs Sep 29, 2022
@ImprovedTube ImprovedTube added the Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not label Sep 29, 2022
@ImprovedTube
Copy link
Member Author

👍 @hboyd2003
edit

@hboyd2003
Copy link
Contributor

@ImprovedTube I see the problem now, thanks for updating the report. It looks like this is an issue with @victor-savinov's Satus library. The version in the ImprovedTube repo is minified so its missing all the readable variable names which makes it hard to understand. @victor-savinov Doesn't have the none-minified version uploaded anywhere so I can't really fix it.

In the future it would be better to have the un-minified version in the repo and just have the minification built into the build script for quicker development.

@hboyd2003 hboyd2003 removed the Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not label Sep 29, 2022
@hboyd2003
Copy link
Contributor

@ImprovedTube Also I don't think there exists a bug that is not already an existing feature, so no real use to adding the feature exists label to bugs it should be used for feature requests where the feature exists in another form (such as a feature that exists in another extension)

@ImprovedTube
Copy link
Member Author

Satus

Exactly! Firefox also requires source / unminified.
@hboyd2003 https://github.com/code-for-charity/YouTube-Extension/blob/v4.0/assets/satus/satus.js


i dont recall adding feature exists :D

@ImprovedTube ImprovedTube added the Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not label Feb 11, 2023
@ImprovedTube ImprovedTube changed the title Extension Instant Search Bugs Extension Instant Search Bugs & Completition Feb 12, 2023
@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too) labels Feb 12, 2023
@ImprovedTube ImprovedTube removed Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too) labels Feb 15, 2023
@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Apr 29, 2023
@ImprovedTube ImprovedTube changed the title Extension Instant Search Bugs & Completition Extension Instant Search & Completition Sep 10, 2023
@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 5, 2023
@ImprovedTube ImprovedTube added the List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes Completion / Revision Rethink, complete, improve, tweak our feature or structure. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) UI (UX) about our UI (UX) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: No status
Development

No branches or pull requests

2 participants