Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest npm version of this package is 1.1.0 #49

Open
Pahicz opened this issue Nov 20, 2020 · 7 comments
Open

Latest npm version of this package is 1.1.0 #49

Pahicz opened this issue Nov 20, 2020 · 7 comments

Comments

@Pahicz
Copy link

Pahicz commented Nov 20, 2020

Could you please update the package in npm to the latest version?
There is 9 months old version and it internaly uses pg package version 6.3.3 which could freeze the whole app, when I want to use it now I need to manually update pg inside the package which is quite annoying (or download it from here).

https://www.npmjs.com/package/sequelize-cockroachdb/v/1.1.0

@rafiss
Copy link
Contributor

rafiss commented Nov 20, 2020

Hi @Pahicz -- thanks for the issue! This project was left ownerless for a while, but the good news is that since last month, we have been working on modernizing the library. Stay tuned for a new version within a few weeks to months.

@Pahicz
Copy link
Author

Pahicz commented Nov 20, 2020

Thanks for the quick reply! That's great to hear that.
If anyone has encountered the same issue, more related info could be found here: brianc/node-postgres#2069

What i did to make it work:

  1. in dependencies node_modules\sequelize-cockroachdb\package.json I changed version "pg": "^6.1.3", to "pg": "~8.3.3",
  2. node_modules\sequelize-cockroachdb> npm update pg@8.3.3

So far it did not crash while I was using it, but of course, that is a completely different version of pg so I guess it might.

@LaurentVB
Copy link

Hi there, is there more visibility on a new release for this lib?
We're currently in the process of migrating from pg to cockroach and depending on master atm, but we wouldn't feel confident going to production like that 😄
Cheers

@jcrocker-ecomon
Copy link

jcrocker-ecomon commented Feb 5, 2021

Hi - glad to see this project is active again!

The new update to NPM: 6.0.0-alpha.0 is missing sequelize from dependencies (package.json) so this is not installed automatically by NPM resulting in an error on start. Can be fixed as seen below.

"dependencies": {
"lodash": "^4.17.20",
"pg": "^8.4.1",
"semver": "^7.3.2",
"sequelize": "^6.3.5" // ADD HERE TO INSTALL WITH NPM
},
"deprecated": false,
"description": "Support using Sequelize with CockroachDB.",
"devDependencies": {
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"chai-datetime": "^1.7.0",
"mocha": "^8.2.0",
"sequelize": "^6.3.5"
},

Thanks!

@papb
Copy link
Contributor

papb commented Feb 5, 2021

The new update to NPM: 6.0.0-alpha.0 is missing sequelize from dependencies (package.json) so this is not installed automatically by NPM resulting in an error on start. Can be fixed as seen below.

Hello! sequelize-cockroachdb supports both Sequelize v5 and v6. You have to install manually which version you want.

@jcrocker-ecomon
Copy link

Hi @papb Ah makes sense - thanks 👍 Is there any concern with sequelize updates? Should one stick to a specific version of v5 or v6 when using? (e.g the ones you use when testing?)? Or should avoiding major updates be enough? Thanks

@papb
Copy link
Contributor

papb commented Feb 10, 2021

Avoiding major updates should be enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants