Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/schemachanger/schemachanger_test: TestConcurrentSchemaChanges failed #129968

Closed
cockroach-teamcity opened this issue Sep 1, 2024 · 4 comments
Closed

pkg/sql/schemachanger/schemachanger_test: TestConcurrentSchemaChanges failed #129968

cockroach-teamcity opened this issue Sep 1, 2024 · 4 comments
Assignees
@fqazi
Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 1, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/sql/schemachanger/schemachanger_test.TestConcurrentSchemaChanges failed on release-24.1 @ 3fe785cf4712decc3dfbfa70c30692c96f18687d:

    schemachanger_test.go:760: RENAME TABLE TO t_72
    schemachanger_test.go:734: DROP SCHEMA TO testsc_64
    schemachanger_test.go:734: DROP SCHEMA TO testsc_64
    schemachanger_test.go:734: DROP SCHEMA TO testsc_64
    schemachanger_test.go:811: Parent database or schema or table is renamed; skipping this column removal.
    schemachanger_test.go:783: ADD COLUMN col_77 TO testdb.testsc_64.t_72
    schemachanger_test.go:807: DROP COLUMN col_77 FROM testdb.testsc_64.t_72
    schemachanger_test.go:783: ADD COLUMN col_82 TO testdb.testsc_64.t_72
    schemachanger_test.go:783: ADD COLUMN col_83 TO testdb.testsc_64.t_72
    schemachanger_test.go:760: RENAME TABLE TO t_84
    schemachanger_test.go:760: RENAME TABLE TO t_85
    schemachanger_test.go:830: CREATE INDEX idx_86 ON testdb.testsc_64.t_85(col_82)
    schemachanger_test.go:807: DROP COLUMN col_83 FROM testdb.testsc_64.t_85
    schemachanger_test.go:783: ADD COLUMN col_87 TO testdb.testsc_64.t_85
    schemachanger_test.go:732: RENAME SCHEMA TO testsc_88
    schemachanger_test.go:732: RENAME SCHEMA TO testsc_89
    schemachanger_test.go:856: DROP INDEX idx_86 FROM testdb.testsc_64.t_85
    schemachanger_test.go:838: Parent database or schema or table is renamed or column is dropped or index already exists; skipping this index creation.
    schemachanger_test.go:807: DROP COLUMN col_82 FROM testdb.testsc_64.t_85
    schemachanger_test.go:734: DROP SCHEMA TO testsc_89
    schemachanger_test.go:732: RENAME SCHEMA TO testsc_92
    schemachanger_test.go:783: ADD COLUMN col_93 TO testdb.testsc_92.t_85
    schemachanger_test.go:760: RENAME TABLE TO t_95
    schemachanger_test.go:807: DROP COLUMN col_93 FROM testdb.testsc_92.t_85
    schemachanger_test.go:762: DROP TABLE t_96
    schemachanger_test.go:838: Parent database or schema or table is renamed or column is dropped or index already exists; skipping this index creation.
    schemachanger_test.go:783: ADD COLUMN col_98 TO testdb.testsc_92.t_95
    schemachanger_test.go:783: ADD COLUMN col_99 TO testdb.testsc_92.t_95
    schemachanger_test.go:807: DROP COLUMN col_98 FROM testdb.testsc_92.t_95
    schemachanger_test.go:830: CREATE INDEX idx_100 ON testdb.testsc_92.t_95(col_99)
    schemachanger_test.go:734: DROP SCHEMA TO testsc_92
    schemachanger_test.go:760: RENAME TABLE TO t_103
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:783: ADD COLUMN col_104 TO testdb.testsc_92.t_103
    schemachanger_test.go:679: rename-db-worker encounters error driver: bad connection; signal to main routine and finish working
    schemachanger_test.go:675: create-index-worker is signaled to finish work
    schemachanger_test.go:675: drop-index-worker is signaled to finish work
    schemachanger_test.go:675: rename-tbl-worker is signaled to finish work
    schemachanger_test.go:675: drop-column-worker is signaled to finish work
    schemachanger_test.go:675: rename-schema-worker is signaled to finish work
    schemachanger_test.go:783: ADD COLUMN col_105 TO testdb.testsc_92.t_103
    schemachanger_test.go:675: add-column-worker is signaled to finish work
    schemachanger_test.go:869: 
        	Error Trace:	pkg/sql/schemachanger/schemachanger_test_test/pkg/sql/schemachanger/schemachanger_test.go:869
        	Error:      	Received unexpected error:
        	            	driver: bad connection
        	Test:       	TestConcurrentSchemaChanges
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentSchemaChanges2514194864
--- FAIL: TestConcurrentSchemaChanges (33.85s)

Parameters:

  • attempt=1
  • run=4
  • shard=24
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-41810
@cockroach-teamcity cockroach-teamcity added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Sep 1, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Sep 1, 2024
@cockroach-teamcity
Copy link
Member Author

pkg/sql/schemachanger/schemachanger_test.TestConcurrentSchemaChanges failed on release-24.1 @ 8d0d27b33018014b28d52799b750e4a8b253501c:

    schemachanger_test.go:762: DROP TABLE t_48
    schemachanger_test.go:762: DROP TABLE t_49
    schemachanger_test.go:762: DROP TABLE t_50
    schemachanger_test.go:762: DROP TABLE t_51
    schemachanger_test.go:783: ADD COLUMN col_53 TO testdb_24.testsc.t_29
    schemachanger_test.go:783: ADD COLUMN col_54 TO testdb_24.testsc.t_29
    schemachanger_test.go:807: DROP COLUMN col_54 FROM testdb_24.testsc.t_29
    schemachanger_test.go:830: CREATE INDEX idx_56 ON testdb_24.testsc.t_29(col_53)
    schemachanger_test.go:807: DROP COLUMN col_53 FROM testdb_24.testsc.t_29
    schemachanger_test.go:783: ADD COLUMN col_55 TO testdb_24.testsc.t_29
    schemachanger_test.go:760: RENAME TABLE TO t_58
    schemachanger_test.go:762: DROP TABLE t_59
    schemachanger_test.go:732: RENAME SCHEMA TO testsc_60
    schemachanger_test.go:734: DROP SCHEMA TO testsc_60
    schemachanger_test.go:734: DROP SCHEMA TO testsc_60
    schemachanger_test.go:783: ADD COLUMN col_64 TO testdb_24.testsc_60.t_58
    schemachanger_test.go:783: ADD COLUMN col_65 TO testdb_24.testsc_60.t_58
    schemachanger_test.go:783: ADD COLUMN col_66 TO testdb_24.testsc_60.t_58
    schemachanger_test.go:807: DROP COLUMN col_66 FROM testdb_24.testsc_60.t_58
    schemachanger_test.go:807: DROP COLUMN col_64 FROM testdb_24.testsc_60.t_58
    schemachanger_test.go:830: CREATE INDEX idx_67 ON testdb_24.testsc_60.t_58(col_65)
    schemachanger_test.go:762: DROP TABLE t_69
    schemachanger_test.go:760: RENAME TABLE TO t_72
    schemachanger_test.go:762: DROP TABLE t_73
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:783: ADD COLUMN col_74 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:783: ADD COLUMN col_75 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:811: Parent database or schema or table is renamed; skipping this column removal.
    schemachanger_test.go:783: ADD COLUMN col_77 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:830: CREATE INDEX idx_76 ON testdb_24.testsc_60.t_72(col_74)
    schemachanger_test.go:734: DROP SCHEMA TO testsc_60
    schemachanger_test.go:783: ADD COLUMN col_80 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:783: ADD COLUMN col_81 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:679: rename-db-worker encounters error driver: bad connection; signal to main routine and finish working
    schemachanger_test.go:675: rename-tbl-worker is signaled to finish work
    schemachanger_test.go:675: drop-index-worker is signaled to finish work
    schemachanger_test.go:675: drop-column-worker is signaled to finish work
    schemachanger_test.go:675: rename-schema-worker is signaled to finish work
    schemachanger_test.go:783: ADD COLUMN col_82 TO testdb_24.testsc_60.t_72
    schemachanger_test.go:675: add-column-worker is signaled to finish work
    schemachanger_test.go:830: CREATE INDEX idx_83 ON testdb_24.testsc_60.t_72(col_82)
    schemachanger_test.go:675: create-index-worker is signaled to finish work
    schemachanger_test.go:869: 
        	Error Trace:	pkg/sql/schemachanger/schemachanger_test_test/pkg/sql/schemachanger/schemachanger_test.go:869
        	Error:      	Received unexpected error:
        	            	driver: bad connection
        	Test:       	TestConcurrentSchemaChanges
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentSchemaChanges1126966217
--- FAIL: TestConcurrentSchemaChanges (20.10s)

Parameters:

  • attempt=1
  • run=3
  • shard=24
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@fqazi fqazi self-assigned this Sep 3, 2024
@cockroach-teamcity cockroach-teamcity mentioned this issue Sep 4, 2024
Open
@github-actions github-actions bot mentioned this issue Sep 4, 2024
Closed
@fqazi fqazi removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 9, 2024
@cockroach-teamcity cockroach-teamcity mentioned this issue Sep 11, 2024
Open
@github-actions GitHub Actions
Copy link

pkg/sql/schemachanger/schemachanger_test.TestConcurrentSchemaChanges failed on release-24.1 @ dab9c1f399d2ecda1a3b81fd750a3c9aef3bc6f9:

    schemachanger_test.go:760: RENAME TABLE TO t_172
    schemachanger_test.go:709: RENAME DATABASE TO testdb_173
    schemachanger_test.go:811: Parent database or schema or table is renamed; skipping this column removal.
    schemachanger_test.go:830: CREATE INDEX idx_174 ON testdb_173.testsc_169.t_172(col_164)
    schemachanger_test.go:783: ADD COLUMN col_175 TO testdb_173.testsc_169.t_172
    schemachanger_test.go:783: ADD COLUMN col_177 TO testdb_173.testsc_169.t_172
    schemachanger_test.go:807: DROP COLUMN col_177 FROM testdb_173.testsc_169.t_172
    schemachanger_test.go:783: ADD COLUMN col_179 TO testdb_173.testsc_169.t_172
    schemachanger_test.go:807: DROP COLUMN col_175 FROM testdb_173.testsc_169.t_172
    schemachanger_test.go:760: RENAME TABLE TO t_181
    schemachanger_test.go:783: ADD COLUMN col_180 TO testdb_173.testsc_169.t_172
    schemachanger_test.go:783: ADD COLUMN col_182 TO testdb_173.testsc_169.t_181
    schemachanger_test.go:863: Parent database or schema or table is renamed or index is dropped; skipping this index removal.
    schemachanger_test.go:807: DROP COLUMN col_180 FROM testdb_173.testsc_169.t_181
    schemachanger_test.go:838: Parent database or schema or table is renamed or column is dropped or index already exists; skipping this index creation.
    schemachanger_test.go:783: ADD COLUMN col_183 TO testdb_173.testsc_169.t_181
    schemachanger_test.go:783: ADD COLUMN col_184 TO testdb_173.testsc_169.t_181
    schemachanger_test.go:856: DROP INDEX idx_174 FROM testdb_173.testsc_169.t_181
    schemachanger_test.go:698: DROP DATABASE testdb_173
    schemachanger_test.go:760: RENAME TABLE TO t_186
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:760: RENAME TABLE TO t_187
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:783: ADD COLUMN col_191 TO testdb_173.testsc_169.t_187
    schemachanger_test.go:783: ADD COLUMN col_198 TO testdb_173.testsc_169.t_187
    schemachanger_test.go:783: ADD COLUMN col_199 TO testdb_173.testsc_169.t_187
    schemachanger_test.go:807: DROP COLUMN col_198 FROM testdb_173.testsc_169.t_187
    schemachanger_test.go:807: DROP COLUMN col_199 FROM testdb_173.testsc_169.t_187
    schemachanger_test.go:838: Parent database or schema or table is renamed or column is dropped or index already exists; skipping this index creation.
    schemachanger_test.go:807: DROP COLUMN col_191 FROM testdb_173.testsc_169.t_187
    schemachanger_test.go:698: DROP DATABASE testdb_173
    schemachanger_test.go:783: ADD COLUMN col_201 TO testdb_173.testsc_169.t_187
    schemachanger_test.go:698: DROP DATABASE testdb_173
    schemachanger_test.go:679: rename-schema-worker encounters error driver: bad connection; signal to main routine and finish working
    schemachanger_test.go:675: drop-index-worker is signaled to finish work
    schemachanger_test.go:675: create-index-worker is signaled to finish work
    schemachanger_test.go:675: add-column-worker is signaled to finish work
    schemachanger_test.go:807: DROP COLUMN col_201 FROM testdb_173.testsc_169.t_187
    schemachanger_test.go:675: drop-column-worker is signaled to finish work
    schemachanger_test.go:675: rename-db-worker is signaled to finish work
    schemachanger_test.go:762: DROP TABLE t_190
    schemachanger_test.go:675: rename-tbl-worker is signaled to finish work
    schemachanger_test.go:869: 
        	Error Trace:	pkg/sql/schemachanger/schemachanger_test_test/pkg/sql/schemachanger/schemachanger_test.go:869
        	Error:      	Received unexpected error:
        	            	driver: bad connection
        	Test:       	TestConcurrentSchemaChanges
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentSchemaChanges2287990908
--- FAIL: TestConcurrentSchemaChanges (70.14s)

Parameters:

  • attempt=1
  • run=1
  • shard=25
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@github-actions github-actions bot mentioned this issue Sep 11, 2024
Closed
@cockroach-teamcity cockroach-teamcity mentioned this issue Sep 13, 2024
Open
@cockroach-teamcity
Copy link
Member Author

pkg/sql/schemachanger/schemachanger_test.TestConcurrentSchemaChanges failed on release-24.1 @ 332094e3e6cbd2671a96b875e8cd4f8e8784d0f5:

    schemachanger_test.go:767: Parent database or schema is renamed; skipping this table renaming.
    schemachanger_test.go:709: RENAME DATABASE TO testdb_420
    schemachanger_test.go:709: RENAME DATABASE TO testdb_422
    schemachanger_test.go:783: ADD COLUMN col_418 TO testdb_407.testsc_415.t_398
    schemachanger_test.go:783: ADD COLUMN col_423 TO testdb_422.testsc_415.t_398
    schemachanger_test.go:783: ADD COLUMN col_424 TO testdb_422.testsc_415.t_398
    schemachanger_test.go:830: CREATE INDEX idx_425 ON testdb_422.testsc_415.t_398(col_423)
    schemachanger_test.go:830: CREATE INDEX idx_426 ON testdb_422.testsc_415.t_398(col_423)
    schemachanger_test.go:783: ADD COLUMN col_427 TO testdb_422.testsc_415.t_398
    schemachanger_test.go:856: DROP INDEX idx_425 FROM testdb_422.testsc_415.t_398
    schemachanger_test.go:732: RENAME SCHEMA TO testsc_430
    schemachanger_test.go:783: ADD COLUMN col_428 TO testdb_422.testsc_415.t_398
    schemachanger_test.go:811: Parent database or schema or table is renamed; skipping this column removal.
    schemachanger_test.go:830: CREATE INDEX idx_432 ON testdb_422.testsc_430.t_398(col_427)
    schemachanger_test.go:807: DROP COLUMN col_428 FROM testdb_422.testsc_430.t_398
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:698: DROP DATABASE testdb_422
    schemachanger_test.go:838: Parent database or schema or table is renamed or column is dropped or index already exists; skipping this index creation.
    schemachanger_test.go:863: Parent database or schema or table is renamed or index is dropped; skipping this index removal.
    schemachanger_test.go:767: Parent database or schema is renamed; skipping this table renaming.
    schemachanger_test.go:783: ADD COLUMN col_436 TO testdb_422.testsc_430.t_398
    schemachanger_test.go:811: Parent database or schema or table is renamed; skipping this column removal.
    schemachanger_test.go:783: ADD COLUMN col_438 TO testdb_422.testsc_430.t_398
    schemachanger_test.go:830: CREATE INDEX idx_439 ON testdb_422.testsc_430.t_398(col_436)
    schemachanger_test.go:807: DROP COLUMN col_438 FROM testdb_422.testsc_430.t_398
    schemachanger_test.go:762: DROP TABLE t_441
    schemachanger_test.go:760: RENAME TABLE TO t_442
    schemachanger_test.go:787: Parent database or schema or table is renamed or column already exists; skipping this column addition.
    schemachanger_test.go:709: RENAME DATABASE TO testdb_445
    schemachanger_test.go:709: RENAME DATABASE TO testdb_448
    schemachanger_test.go:783: ADD COLUMN col_444 TO testdb_422.testsc_430.t_442
    schemachanger_test.go:698: DROP DATABASE testdb_448
    schemachanger_test.go:709: RENAME DATABASE TO testdb_449
    schemachanger_test.go:698: DROP DATABASE testdb_449
    schemachanger_test.go:679: rename-schema-worker encounters error driver: bad connection; signal to main routine and finish working
    schemachanger_test.go:675: rename-tbl-worker is signaled to finish work
    schemachanger_test.go:675: drop-column-worker is signaled to finish work
    schemachanger_test.go:675: add-column-worker is signaled to finish work
    schemachanger_test.go:675: create-index-worker is signaled to finish work
    schemachanger_test.go:675: drop-index-worker is signaled to finish work
    schemachanger_test.go:675: rename-db-worker is signaled to finish work
    schemachanger_test.go:869: 
        	Error Trace:	pkg/sql/schemachanger/schemachanger_test_test/pkg/sql/schemachanger/schemachanger_test.go:869
        	Error:      	Received unexpected error:
        	            	driver: bad connection
        	Test:       	TestConcurrentSchemaChanges
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestConcurrentSchemaChanges100882122
--- FAIL: TestConcurrentSchemaChanges (134.78s)

Parameters:

  • attempt=1
  • run=19
  • shard=25
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Sep 18, 2024
@fqazi fqazi mentioned this issue Sep 18, 2024
Merged
@fqazi
Copy link
Collaborator

fqazi commented Sep 18, 2024

Fixed via: #130961

@fqazi fqazi closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
24.1
Development

No branches or pull requests
2 participants
@fqazi @cockroach-teamcity