Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress for Database #76

Closed
chrislovecnm opened this issue Jul 14, 2020 · 4 comments
Closed

Ingress for Database #76

chrislovecnm opened this issue Jul 14, 2020 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@chrislovecnm
Copy link
Contributor

The helm chart supports the creations of an ingress object. Do we support this in the operator

# CockroachDB's ingress for web ui.
ingress:
  enabled: false
  labels: {}
  annotations: {}
  #   kubernetes.io/ingress.class: nginx
  #   cert-manager.io/cluster-issuer: letsencrypt
  paths: [/]
  hosts: []
  # - cockroachlabs.com
  tls: []
  # - hosts: [cockroachlabs.com]
  #   secretName: cockroachlabs-tls

https://github.com/cockroachdb/helm-charts/blob/25e4598e13fa9402242d837e828a550a20e8a648/cockroachdb/values.yaml#L245

@johnrk-zz johnrk-zz added the good first issue Good for newcomers label Nov 24, 2020
@chrislovecnm chrislovecnm added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Dec 8, 2020
@chrislovecnm
Copy link
Contributor Author

@johnrk this is a pretty big issue for "first issue", so I changed it to help wanted. We do need it, and after working on a couple of "first issues" this is a good issue to take on as you understand the code more.

@Szymongib
Copy link

Hi @chrislovecnm,
Do I understand correctly, that the objective would be to create Ingress in Operator based on the configuration specified in the CrdbCluster CR? With config options mimicking the ones from the Helm chart?

If that is the case, would you mind if I take a stab at that?

@chrislovecnm
Copy link
Contributor Author

@Szymongib i think our first iteration should be an internal elb.

we always appreciate help!

@pseudomuto
Copy link
Contributor

Closed by #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants