fix: add NoBindingEmbedding to the iOS binding projects.

"NoBindingEmbedding = True" is required when using an XCFramework, otherwise the comsuming app project will get linker errors on all Objective-C classes. xamarin/xamarin-macios#10774 (comment)
cobrowseio · Dec 18, 2021 · e11debd · e11debd
1 parent 6dcab84
commit e11debd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/iOS/CobrowseIO.AppExtension.iOS/CobrowseIO.AppExtension.iOS.csproj b/iOS/CobrowseIO.AppExtension.iOS/CobrowseIO.AppExtension.iOS.csproj
@@ -12,6 +12,7 @@
     <AssemblyName>CobrowseIO.AppExtension.iOS</AssemblyName>
     <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
     <Description>https://github.com/cobrowseio/cobrowse-sdk-ios-binary/tree/master/CobrowseIOAppExtension.xcframework</Description>
+    <NoBindingEmbedding>true</NoBindingEmbedding>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>

diff --git a/iOS/CobrowseIO.iOS/CobrowseIO.iOS.csproj b/iOS/CobrowseIO.iOS/CobrowseIO.iOS.csproj
@@ -12,6 +12,7 @@
     <AssemblyName>CobrowseIO.iOS</AssemblyName>
     <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
     <Description>https://github.com/cobrowseio/cobrowse-sdk-ios-binary</Description>
+    <NoBindingEmbedding>true</NoBindingEmbedding>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>

diff --git a/iOS/Starscream.iOS/Starscream.iOS.csproj b/iOS/Starscream.iOS/Starscream.iOS.csproj
@@ -12,6 +12,7 @@
     <AssemblyName>Starscream.iOS</AssemblyName>
     <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
     <Description>https://github.com/daltoniam/Starscream</Description>
+    <NoBindingEmbedding>true</NoBindingEmbedding>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>

diff --git a/iOS/SwiftCBOR.iOS/SwiftCBOR.iOS.csproj b/iOS/SwiftCBOR.iOS/SwiftCBOR.iOS.csproj
@@ -12,6 +12,7 @@
     <AssemblyName>SwiftCBOR.iOS</AssemblyName>
     <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
     <Description>https://github.com/myfreeweb/SwiftCBOR</Description>
+    <NoBindingEmbedding>true</NoBindingEmbedding>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DebugSymbols>true</DebugSymbols>