Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip tag name out of utf8mb3 #440

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

hezhengxu2018
Copy link
Collaborator

@hezhengxu2018 hezhengxu2018 commented Apr 9, 2023

closes #438

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #440 (a1b6853) into master (cf95d7d) will decrease coverage by 0.20%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   97.30%   97.10%   -0.20%     
==========================================
  Files         157      157              
  Lines       14118    14123       +5     
  Branches     1816     1811       -5     
==========================================
- Hits        13737    13714      -23     
- Misses        381      409      +28     
Impacted Files Coverage Δ
app/core/service/PackageSyncerService.ts 98.31% <40.00%> (-0.36%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hezhengxu2018 不建议支持超出 ascii 字符集的 tag,不友好。
这个历史npm包的 tag 可以做一下代码逻辑判断,不同步超出目前 tag 数据库支持的字符集的版本,直接忽略就好。

@fengmk2 fengmk2 added the bug Something isn't working label Apr 10, 2023
@hezhengxu2018 hezhengxu2018 marked this pull request as draft April 10, 2023 04:08
@hezhengxu2018 hezhengxu2018 changed the title fix: support unicode tag name. fix: skip tag name out of utf8mb3. Apr 10, 2023
@hezhengxu2018 hezhengxu2018 marked this pull request as ready for review April 10, 2023 07:42
sql/1.10.0.sql Outdated Show resolved Hide resolved
@fengmk2 fengmk2 changed the title fix: skip tag name out of utf8mb3. fix: skip tag name out of utf8mb4 Apr 10, 2023
@fengmk2 fengmk2 changed the title fix: skip tag name out of utf8mb4 fix: skip tag name out of utf8mb3 Apr 10, 2023
@fengmk2 fengmk2 merged commit a64c90b into cnpm:master Apr 10, 2023
fengmk2 pushed a commit that referenced this pull request Apr 10, 2023
[skip ci]

## [3.13.2](v3.13.1...v3.13.2) (2023-04-10)

### Bug Fixes

* skip tag name out of utf8mb3 ([#440](#440)) ([a64c90b](a64c90b))
@github-actions
Copy link

🎉 This PR is included in version 3.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fengmk2
Copy link
Member

fengmk2 commented Apr 10, 2023

生效

[2023-04-10T10:27:14.069Z] 👉👉👉👉👉 Tips: Sync cause by "http://r.cnpmjs.org/aproba/sync?sync_upstream=true&nodeps=true", parent traceId: 426b9980-d78a-11ed-b579-ddae94ff40f7 👈👈👈👈👈
[2023-04-10T10:27:14.069Z] 🚧🚧🚧🚧🚧 Syncing from https://registry.npmjs.org/aproba, skipDependencies: true, syncUpstream: false, syncDownloadData: false, forceSyncHistory: false attempts: 1, worker: "cnpmcore-01/2734160", taskQueue: 0/100 🚧🚧🚧🚧🚧
[2023-04-10T10:27:14.069Z] 🚧 log: https://r.cnpmjs.org/-/package/aproba/syncs/6433e481e985ddb876210a11/log
[2023-04-10T10:27:15.010Z] HTTP [200] content-length: -, timing: {"queuing":0.092,"connected":0,"requestHeadersSent":0.117,"requestSent":0.16,"waiting":939.577,"contentDownload":939.951}
[2023-04-10T10:27:15.010Z] 📖 aproba latest version: 2.0.0, published time: "2018-05-22T21:29:46.504Z"
[2023-04-10T10:27:15.010Z] 🚧 Syncing maintainers: [{"name":"iarna","email":"me@re-becca.org"}]
[2023-04-10T10:27:15.161Z] 🚧 Syncing versions 10 => 10
[2023-04-10T10:27:15.161Z] 🟢 Synced updated 0 versions, removed 0 versions
[2023-04-10T10:27:15.163Z] 🚧 invalid tag(😄: 1.1.1), tag name is out of utf8mb3, skip
[2023-04-10T10:27:15.342Z] 🟢 Synced 1 tags: [{"action":"remove","tag":""}]
[2023-04-10T10:27:15.347Z] 🟢 Clean cache
[2023-04-10T10:27:15.347Z] 🟢 log: https://r.cnpmjs.org/-/package/aproba/syncs/6433e481e985ddb876210a11/log
[2023-04-10T10:27:15.347Z] 🟢🟢🟢🟢🟢 https://registry.npmjs.org/aproba?t=1681122434069&cache=0 🟢🟢🟢🟢🟢

@hezhengxu2018 hezhengxu2018 deleted the fix-support-unicode-tag branch April 17, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag中的emoji字符导致同步tag失败
2 participants