Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeout handler not work #430

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix: timeout handler not work #430

merged 3 commits into from
Mar 30, 2023

Conversation

elrrrrrrr
Copy link
Member

💥 TaskTimeoutHandler did not have try-catch, the redis lock will cause all queues to fail when a single task update failed.

  • 🛡️ Added try-catch statements in TaskTimeoutHandler.
  • 🚧 Restricted updates to the primary key when updating the model in ModelConvertor.

💥 TaskTimeoutHandler 未添加 try-catch，且有同步锁，导致单个任务更新异常时，所有队列不生效

  • 🛡️ TaskTimeoutHandler 统一添加 try-catch
  • 🚧 ModelConvertor 更新模型时，统一限制不允许更新主键

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Mar 29, 2023
@elrrrrrrr elrrrrrrr requested review from fengmk2, gemwuu and killagu March 29, 2023 15:06
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #430 (f71b320) into master (4ee410a) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   97.26%   97.09%   -0.18%     
==========================================
  Files         156      156              
  Lines       13983    13997      +14     
  Branches     1790     1792       +2     
==========================================
- Hits        13601    13590      -11     
- Misses        382      407      +25
Impacted Files Coverage Δ
app/core/service/TaskService.ts 97.91% <100.00%> (-1.53%) ⬇️
app/repository/util/ModelConvertor.ts 91.48% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@elrrrrrrr elrrrrrrr changed the title fix: timeout handler not work WIP: fix: timeout handler not work Mar 30, 2023
@elrrrrrrr elrrrrrrr changed the title WIP: fix: timeout handler not work fix: timeout handler not work Mar 30, 2023
gemwuu
gemwuu approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@gemwuu gemwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

killagu
killagu approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 3f83808 into master Mar 30, 2023
@killagu killagu deleted the tiemout-handler branch March 30, 2023 05:11
fengmk2 pushed a commit that referenced this pull request Mar 30, 2023
@semantic-release-bot
Release 3.11.1
30e9140 
[skip ci]

## [3.11.1](v3.11.0...v3.11.1) (2023-03-30)

### Bug Fixes

* timeout handler not work ([#430](#430)) ([3f83808](3f83808))
* update login assets cdn url ([#429](#429)) ([4ee410a](4ee410a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

@gemwuu gemwuu gemwuu approved these changes

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elrrrrrrr @gemwuu @killagu