Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unpublish pkg when upstream block #372

Merged
merged 1 commit into from
Jan 5, 2023
Merged

feat: unpublish pkg when upstream block #372

merged 1 commit into from
Jan 5, 2023

Conversation

elrrrrrrr
Copy link
Member

https://registry.npmmirror.com/chalk-next
如果上游 cnpmcore registry block 包时，下游同步时目前会同步失败，导致包无法自动废弃

  • 上游包 unblock 时，下游包应当 unpublish 处理，follow upstream 操作

@elrrrrrrr elrrrrrrr added the enhancement New feature or request label Jan 5, 2023
@elrrrrrrr elrrrrrrr force-pushed the unpublish-when-upstream-block branch from 02a6e34 to 0122198 Compare January 5, 2023 12:11
@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #372 (0122198) into master (bda3f1c) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   97.62%   97.41%   -0.21%     
==========================================
  Files         151      151              
  Lines       12831    12834       +3     
  Branches     1678     1673       -5     
==========================================
- Hits        12526    12502      -24     
- Misses        305      332      +27
Impacted Files Coverage Δ
app/core/service/PackageSyncerService.ts 99.34% <100.00%> (+<0.01%) ⬆️
config/config.default.ts 86.98% <0.00%> (-8.88%) ⬇️
app/infra/NFSClientAdapter.ts 86.58% <0.00%> (-8.54%) ⬇️
app/core/service/TaskService.ts 97.77% <0.00%> (-1.67%) ⬇️
app/common/adapter/binary/PuppeteerBinary.ts 98.47% <0.00%> (-0.77%) ⬇️
app/core/service/PackageManagerService.ts 97.51% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 merged commit 7e419c1 into master Jan 5, 2023
@fengmk2 fengmk2 deleted the unpublish-when-upstream-block branch January 5, 2023 12:34
fengmk2 pushed a commit that referenced this pull request Jan 5, 2023
@semantic-release-bot
Release 2.10.0
6384229 
[skip ci]

## [2.10.0](v2.9.1...v2.10.0) (2023-01-05)

### Features

* unpublish pkg when upstream block ([#372](#372)) ([7e419c1](7e419c1))
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@gemwuu gemwuu Awaiting requested review from gemwuu

@killagu killagu Awaiting requested review from killagu

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrrrrrrr @fengmk2