Revert "feat: set allowH2 to true and require Node.js >= 18 (#705)"

[fengmk2]

This reverts commit 9a79940.

Summary by CodeRabbit

• New Features

  • Updated HTTP client configuration to enhance compatibility.
  • Adjusted minimum Node.js version requirement for broader support.

• Bug Fixes

  • Removed HTTP/2 support from the HTTP client configuration.

[coderabbitai]

Walkthrough

The changes involve modifications to the HTTP client configuration in config/config.default.ts, specifically the removal of the allowH2 property, which disables HTTP/2 support. Additionally, the package.json file has been updated to lower the minimum required version of Node.js from >= 18.20.0 to >= 16.13.0, reflecting a change in compatibility requirements for the project.

Changes

File	Change Summary
config/config.default.ts	Removed allowH2 configuration property, disabling HTTP/2 support.
package.json	Updated minimum Node.js version requirement from >= 18.20.0 to >= 16.13.0.

Possibly related PRs

• feat: set allowH2 to true and require Node.js >= 18 #705: This PR modifies the allowH2 configuration in config/config.default.ts and also updates the Node.js version requirement in package.json, indicating a direct relationship in the changes made to the HTTP client configuration.

🐰 In the code, we hop and play,
With settings changed, we find our way.
HTTP/2, we bid adieu,
Node.js version, we adjust too!
A leap for all, both big and small,
In this code garden, we thrive and sprawl! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0a0c4e7 and c79d042.

📒 Files selected for processing (2)

• config/config.default.ts (0 hunks)
• package.json (1 hunks)

💤 Files not reviewed due to no reviewable changes (1)

• config/config.default.ts

🔇 Additional comments not posted (1)

package.json (1)

148-148: Verify compatibility with Node.js 16.13.0 and consider security implications

The change in the minimum required Node.js version from 18.20.0 to 16.13.0 aligns with the PR objective to revert a previous commit. However, this downgrade raises several considerations:

1. Compatibility: Ensure that all dependencies in the project are compatible with Node.js 16.13.0. Some packages might have dropped support for older Node.js versions.

2. Features: Node.js 18 introduced several new features and improvements. Verify that the codebase doesn't rely on any Node.js 18+ specific features.

3. Security: Node.js 16.13.0 is an older version and may not include the latest security patches. Consider the security implications of using this version, especially if the application is deployed in a production environment.

4. Long-term support: Node.js 16 reached its end-of-life on September 11, 2023. Using an unsupported version in production is not recommended.

5. Performance: Newer Node.js versions often come with performance improvements. Reverting to an older version might impact the application's performance.

To ensure compatibility, run the following script to check for any dependencies that require Node.js >= 18:

Given these considerations, please clarify the reason for reverting to Node.js 16.13.0. If this is a temporary measure, consider adding a TODO comment or creating an issue to track the need for upgrading back to a more recent, supported Node.js version in the future.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

🚮 Removed packages: npm/node-rsa@1.1.1, npm/npm-package-arg@10.1.0, npm/oss-cnpm@5.0.1, npm/p-map@4.0.0, npm/s3-cnpmcore@1.1.2, npm/semver@7.6.3, npm/ssri@8.0.1, npm/type-fest@2.19.0, npm/typescript@5.2.2, npm/ua-parser-js@1.0.39, npm/validate-npm-package-name@3.0.0

View full report↗︎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (9a79940) to head (c79d042).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   96.81%   96.81%   -0.01%     
==========================================
  Files         181      181              
  Lines       18004    18003       -1     
  Branches     2345     2338       -7     
==========================================
- Hits        17430    17429       -1     
  Misses        574      574              

Flag	Coverage Δ
	96.81% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fengmk2]