Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock babel-traverse 7.17.10 to 7.17.9 #192

Merged
merged 1 commit into from
May 5, 2022

Conversation

SoloJiang
Copy link
Contributor

@SoloJiang SoloJiang commented May 5, 2022

@atian25 atian25 changed the title chore: revert babel-traverse version to 7.17.9 fix: lock babel-traverse 7.17.10 to 7.17.9 May 5, 2022
@atian25 atian25 merged commit 03f2983 into cnpm:master May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

🎉 This PR is included in version 1.73.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

liuxingbaoyu added a commit to liuxingbaoyu/bug-versions that referenced this pull request May 9, 2022
@fengzee
Copy link

fengzee commented May 9, 2022

这其实是个 workaround,DCL 插件已经在 babel/minify@335cb88 给出了问题 babel/babel#14525 的实际修复。确保用上这个修复(DCL 0.5.2)后,即使用 @babel/traverse 7.17.10,也是没有问题的。

@SoloJiang
Copy link
Contributor Author

是的,但是实际上如果和错误版本的 minify plugin 一起使用依然属于 traverse 变更导致的 break change or bug

@xuemanchi
Copy link

xuemanchi commented May 10, 2022

这个pr导致项目lock文件原先使用1.70.10生成的 integrity 现在校验失败 项目lock都得重新生成一次...

@SoloJiang
Copy link
Contributor Author

我理解本质是 bug version 的机制?如果存在 bug 的版本,版本号被写入 lock 文件,重新生成是必要的?

fengmk2 pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants