Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Control - Use icon for Layer menu instead of text link. #231

Closed
tmcgee opened this issue Sep 26, 2014 · 13 comments
Closed

Layer Control - Use icon for Layer menu instead of text link. #231

tmcgee opened this issue Sep 26, 2014 · 13 comments
Assignees

Comments

@tmcgee
Copy link
Member

tmcgee commented Sep 26, 2014

In issue #229, I mentioned that an icon is a good user interface addition for the layer menu within LayerControl widget. This new issue is created to track this idea separately so as not to subvert the original enhancement request any further. The icon would replace or supplement the text link that is currently used to bring up the menu.

As far as which icon to use...

@dspriggs suggested a cog icon. http://fontawesome.io/icon/cog/

This is becoming the "universal" menu icon and so is a potential candidate: http://fontawesome.io/icon/bars/ I prefer it over the cog icon.

@DavidSpriggs
Copy link
Member

I like the bars as well.

@jebu75
Copy link
Collaborator

jebu75 commented Sep 26, 2014

I like the bars icon as well.

@btfou
Copy link
Contributor

btfou commented Sep 26, 2014

Bars it is. Thanks.

@btfou
Copy link
Contributor

btfou commented Sep 26, 2014

@tmcgee @DavidSpriggs @jebu75 Any thoughts on color? Maybe a slightly lighter grey and default (#333) on hover?

@jebu75
Copy link
Collaborator

jebu75 commented Sep 26, 2014

Sounds good. What about mobile? The only thing I don't like about a small menu icon is implications for touch devices. The hyperlink is pretty easy to hit with a fat finger. A small icon might be more difficult.

@tmcgee
Copy link
Member Author

tmcgee commented Sep 26, 2014

Something like that lighter grey or perhaps the blue you used for the text link (if the text link is removed).

@tmcgee
Copy link
Member Author

tmcgee commented Sep 26, 2014

@jebu has a valid point. However it is a bigger issue. The plus/minus icons and the folder icons are the same small target size as are many others.

I'm envisioning a mobile css file that is conditionally loaded (using dojo/has). The css file would have larger icons/fonts and other mobile specific classes. Moving to FA and away from images makes that much easier. Sounds like we need to open another new issue to discuss?

@jebu75
Copy link
Collaborator

jebu75 commented Sep 26, 2014

I think @tmcgee is right. I was reviewing one of our apps with some users today and one of the issues that came up was the icons to collapse the side panes being a bit small for use on a touch device.

@btfou
Copy link
Contributor

btfou commented Sep 26, 2014

I'll default to icon (bars) with a parameter to alternately to use the title link.

@jebu75
Copy link
Collaborator

jebu75 commented Sep 26, 2014

I still like the bars icon for now and then @tmcgee’s idea of doing a better job of handling mobile globally. I don’t think you want to over complicate configuration options for the layer controller. With that in mind could the entire layer title and bar icon be clickable without styling the title as a hyperlink? It would provide a better visual hinting (bar icon) to the user and work better on mobile as well.

@tmcgee
Copy link
Member Author

tmcgee commented Sep 26, 2014

I agree with @jebu75 to keep it simple. Use the icon as the visual hint. Make the entire title clickable but no colored link styling for the text. If somebody want to add color or other frills for their own app, they are free to do so.

@btfou
Copy link
Contributor

btfou commented Sep 26, 2014

@jebu75 @tmcgee Thanks for the help sorting this out.

@btfou btfou added this to the v1.4.0 milestone Sep 27, 2014
@btfou btfou removed this from the v1.4.0 milestone Nov 14, 2014
@btfou
Copy link
Contributor

btfou commented Nov 14, 2014

The menu icon has been added and menu link removed as of v1.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants