From 1e952d17d0b5ad32220c5bb5e638744d607c7973 Mon Sep 17 00:00:00 2001 From: Javier Date: Tue, 6 Jul 2021 18:59:44 +0200 Subject: [PATCH 1/2] Set assertLegacySafe to False --- DQMServices/Core/python/DQMStore_cfi.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/DQMServices/Core/python/DQMStore_cfi.py b/DQMServices/Core/python/DQMStore_cfi.py index 5650ea1f0ac36..a550fc99ffce3 100644 --- a/DQMServices/Core/python/DQMStore_cfi.py +++ b/DQMServices/Core/python/DQMStore_cfi.py @@ -9,7 +9,9 @@ #Following list has no effect if saveByLumi is False MEsToSave = cms.untracked.vstring(nanoDQMIO_perLSoutput.MEsToSave), trackME = cms.untracked.string(""), - + #Legacy code should be out. Suggested on: + #https://github.com/cms-sw/cmssw/pull/34231#issuecomment-874789622 + assertLegacySafe = cms.untracked.bool(False), # UNUSED: historical HLT configs expect this option to be present, so it # remains here, even though the DQMStore does not use it any more. enableMultiThread = cms.untracked.bool(True) From bf438ffba1de6ddc84d97be4bc5ce31efc07c610 Mon Sep 17 00:00:00 2001 From: Javier Date: Wed, 7 Jul 2021 09:34:30 +0200 Subject: [PATCH 2/2] Update README.md --- DQMServices/Core/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DQMServices/Core/README.md b/DQMServices/Core/README.md index 161e660428c43..1c0f350d5f439 100644 --- a/DQMServices/Core/README.md +++ b/DQMServices/Core/README.md @@ -97,7 +97,7 @@ Actions on the `DQMStore` are usually indirect and done via the `IBooker` and `I The behavior of the `DQMStore` is not affected by any configuration options (this differs from earlier implementations, where multiple _modes_ existed). Yet, there are a few options that can be set: - There are two options to control per-lumi saving (`saveByLumi` in the `DQMStore`) and harvesting (`reScope` in `DQMRootSource`). Both can be expressed in terms of _Scope_, see later. These options do not affect what the `DQMStore` itself does: `saveByLumi` affects the default scope and is passed down to the booking code in the DQM modules, while `reScope` is handled in the input sources. -- Another option, `assertLegacySafe`, only adds assertions to make sure no operations that would be unsafe in the presence of legacy modules sneak in. It does not affect the behaviour.It is enabled by default, but should be disabled in production RECO jobs where concurrent lumisections are expected. +- Another option, `assertLegacySafe`, only adds assertions to make sure no operations that would be unsafe in the presence of legacy modules sneak in. It does not affect the behaviour. It is disabled by default and indeed it should be kept disabled in production RECO jobs where concurrent lumisections are expected. - The `verbose` option should not affect the behavior. Setting it to a value of at least 4 will enable printing a backtrace for every booking call. - The `trackME` option is a tool for debugging. When it is set, the `DQMStore` will log all life cycle events affecting MEs matching this name. This does not include things done to the ME (like filling -- the `DQMStore` is not involved there), but it does include creation, reset, recycling, and saving of MEs.