Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAHI-Alpaka improvements #45651

Open
kakwok opened this issue Aug 6, 2024 · 5 comments
Open

MAHI-Alpaka improvements #45651

kakwok opened this issue Aug 6, 2024 · 5 comments

Comments

@kakwok
Copy link
Contributor

kakwok commented Aug 6, 2024

This is a collection of topics left out of the initial migration of MAHI to Alpaka #44910
Some details of these topics are included in the HCAL PSG slides.

Technical improvements:

  1. Protection against wrong number of digi sample: #44541
  2. Use EIGEN_COLUMNS, instead of n arrays.
    • For DigiSoA and MahiConditionsSoA
  3. Optimize Stride usage of DigiSoA
  4. Related to #45595, remove rechits with chi2<0 from the output rechits

Algorithmic improvements:

  1. Missing Method-0 features, containment and time slew : line
  2. Related to technical (1), extend Alpaka-MAHI to work in different digi length
  3. Non-deterministic behavior for TS with same energy: line
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

A new Issue was created by @kakwok.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Aug 6, 2024

assign heterogeneous, reconstruction

FYI @cms-sw/hcal-dpg-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

New categories assigned: heterogeneous,reconstruction

@fwyzard,@jfernan2,@makortel,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 4, 2024

FYI @abdoulline @igv4321 as HCAL reco contacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants