mkFit To-Do list

[clacaputo]

The issue is intended to keep track of the mkFit pending to-do items coming from mkFit external integration that are going to be addressed in future PRs.
The list has been taken from #36546 (comment)

Short/medium term

• Get Magnetic field from EventSetup (shorter term)
• Make the minCCC configurable (currently hardcoded as kMinChargePerCM = 1620) (shorter term)
• Get rid of (or avoid?) a copy of enum class TrackAlgorithm and related strings (copied from reco::Track) (shorter/medium term)
  • use cases in runFunctions.cc should better just use the IterationConfig correctly WriteMemoryFile.cc needs to check only for iter0: can hardcode this
  • IterationConfig.cc (uses the string names) could perhaps be dependent on CMSSW DataFormats/TrackReco/interface/TrackBase.h
• magic numbers (repeated literals) in layer indexing (short term)

Long term

• Cleanup of CMS-2017.cc, CMS-2017.acc, and CMS-2017-HitSelectionWindows.h .vs. createPhase1TrackerGeometry.cc, createPhase1TrackerGeometryAutoGen.acc
  • fix with proper mkfit geometry extraction in CMSSW (longer term) --> [MkFit] Tracker geometry extraction from Reco geom modules #37418
    mkFit external integration #36546 (comment)
    mkFit external integration #36546 (comment)
• Cleanup and remove Ice/ --> [MkFit] Use binnor for seed and hit sorting, remove Ice/ #37586
  • fix with the usage of binnor in seed-sorting, check radix-sort vs. std::sort
    mkFit external integration #36546 (comment)
    … and following 4 comments.
  • remove -Wno-error=strict-aliasing from RecoTracker/MkFitCore/BuildFile.xml(short term)
• material description from reco geometry/ES
  mkFit external integration #36546 (comment)
  (there are also arrays of constants in Config.h) (longer term)
• Re-consollidate BH / Std / CE / MIMI so all methods can be used again.
  • use same seed cleaning / dup-removal functions, clean out old ones. (longer term)
• Improve/properly treat 0 Tesla case (longer term)

[cmsbuild]

A new Issue was created by @clacaputo Claudio Caputo.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[clacaputo]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@jpata,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[clacaputo]

assign tracking-pog

[cmsbuild]

New categories assigned: tracking-pog

@mmusich,@mtosi,@vmariani you have been requested to review this Pull request/Issue and eventually sign? Thanks

[clacaputo]

FYI @mmasciov @osschar

[jpata]

type tracking

@clacaputo can you update the PR, ticking what was already implemented? (only the author can)

[slava77]

Cleanup of CMS-2017.cc, CMS-2017.acc, and CMS-2017-HitSelectionWindows.h .vs. createPhase1TrackerGeometry.cc, createPhase1TrackerGeometryAutoGen.acc

* fix with proper mkfit geometry extraction in CMSSW (longer term)

I think that this one was addressed in #37418

while

material description from reco geometry/ES

is not addressed yet