-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem with PoolDBOutputService and PPSAssociationCuts #35667
Comments
A new Issue was created by @jan-kaspar . @Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
diff --git a/CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc b/CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc
index 97f0eb3d4bb..6d2dbe84b24 100644
--- a/CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc
+++ b/CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc
@@ -41,7 +41,7 @@ void WritePPSAssociationCuts::analyze(const edm::Event &iEvent, const edm::Event
// store the data in a DB object
edm::Service<cond::service::PoolDBOutputService> poolDbService;
if (poolDbService.isAvailable()) {
- poolDbService->writeOne(&ppsAssociationCuts, poolDbService->currentTime(), "PPSAssociationCutsRcd");
+ poolDbService->writeOneIOV(&ppsAssociationCuts, poolDbService->currentTime(), "PPSAssociationCutsRcd");
} else {
throw cms::Exception("WritePPSAssociationCuts") << "PoolDBService required.";
} will do. |
assign db |
New categories assigned: db @ggovi,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Many thanks @mmusich ! @wpcarvalho or @grzanka would you have possibly a chance to open a PR with the proposed fix, please? |
I submitted this PR: #35669 |
Hi @tvami no problem and many thanks for the PR! |
In CMSSW_12_1_0_pre4, running the command below on lxplus7
leads to a crash:
By commenting this line
https://github.com/cms-sw/cmssw/blob/master/CondTools/CTPPS/plugins/WritePPSAssociationCuts.cc#L44
the crash is avoided. Thus I guess this comes from some kind of interaction between PoolDBOutputService and PPSAssociationCuts.
By inserting print outs, I could check that
WritePPSAssociationCuts::analyze
gets successfully to the end. Thus I guess the problem occurs at destruction time.Any help appreciated! Many thanks in advance!
The text was updated successfully, but these errors were encountered: