Failure in building a _DBG release

[Dr15Jones]

CMSSW_12_0_DBG_X_2021-05-13-2300 had several compilation failures. This issue is meant to track progress on fixing them.

The packages with compilation failures are

• CondTools/Ecal
• L1Trigger/CSCTrackFinder
• L1Trigger/DTTriggerPhase2
• SimTransport/PPSProtonTransport
• Validation/HGCalValidation

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

#33719 fixes Validation/HGCalValidation

[Dr15Jones]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

I'll look into the build failure of CondTools/Ecal.

[gartung]

Copied from TBB issue
Validation/HGCalValidation #33719
RecoPixelVertexing/PixelVertexFinding #33718

[Dr15Jones]

@smuzaffar @mrodozov So I created a CMSSW_12_0_DBG_X_2021-05-13-2300 work area (at FNAL), checked out CondTools/Ecal and it compiled without issue. Why didn't this fail like the IB?

[Dr15Jones]

@smuzaffar @mrodozov I can answer my own question, doing scram b -v I see that debugging is actually NOT turned on implicitly when using that build. What are all the environment variable I must set to get the same build environment?

[Dr15Jones]

So I discovered that compiling using USER_CXXFLAGS set to -O0 -g3 compiled fine but using -O3 -g3 -DEDM_ML_DEBUG lead to the compilation failure.

[mrodozov]

I had that issue already yesterday, sorry for not mentioning it, I've used the USER_CXXFLAGS="-g -O3 _DEDM_ML_DEBUG" in front of scram commands like:
USER_CXXFLAGS="-g -O3 _DEDM_ML_DEBUG" scram b -j 100
or the same as in the additional build options for the _DBG_ build:
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_12_0_X/master/cmssw-queue-override.file#L17

[dan131riley]

Best to use -g -O0 -DEDM_ML_DEBUG, as some of the failures are from conditional debug code, and some are from code that doesn't compile without the optimizer.

[Dr15Jones]

See #33737

[Dr15Jones]

Interesting, the use of -O3 -g actually allowed the compiler to see that the original code would read outside of the array. Using -O0 or -O2 did not find the problem.

[smuzaffar]

@Dr15Jones , you need to use

USER_CXXFLAGS="-g -O3 -DEDM_ML_DEBUG"  scram build

Once back to work, I will update the configuratin to make these flags defaults for the _DBG IBs

[Dr15Jones]

See #33739 #33740 and #33741

[smuzaffar]

+core
build errors for dbg Ibs are fixed now

[cmsbuild]

This issue is fully signed and ready to be closed.