-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4Hep] Tracker Phase II numeric special parameters need to be passed to an evaluator #32414
Comments
A new Issue was created by @ianna Ianna Osborne. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign geometry |
New categories assigned: geometry @Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Ha I see was done here for Phase 1, following recent change in FilteredView: 32a0c74#diff-7302cd669ba77ff993549a7ab094d7feac189f27ed543dd1970d854dd78b3c05 |
+1 |
This issue is fully signed and ready to be closed. |
Addressing thread-safety and performance. Showstopper for running 2026 DD4Hep workflows. Urgent.
In order to reduce the DD4Hep exposure to RECO all "special" numeric parameters must be marked with
eval=true
. This allows passing it to an evaluator at the time of the XML parsing. Further access to the parameters fromDDFilteredView
isget<double>
WARNING: If the parameter is not marked to be evaluated, it's treated as a
string
. Access to thestring
parameters viaDDFilteredView
get<double>
is forbidden: currently a value0
is returned, further restriction is being implemented to returnNaN
.The text was updated successfully, but these errors were encountered: