Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4Hep] Tracker Phase II numeric special parameters need to be passed to an evaluator #32414

Closed
ianna opened this issue Dec 8, 2020 · 7 comments

Comments

@ianna
Copy link
Contributor

ianna commented Dec 8, 2020

Addressing thread-safety and performance. Showstopper for running 2026 DD4Hep workflows. Urgent.

In order to reduce the DD4Hep exposure to RECO all "special" numeric parameters must be marked with eval=true. This allows passing it to an evaluator at the time of the XML parsing. Further access to the parameters from DDFilteredView is get<double>

WARNING: If the parameter is not marked to be evaluated, it's treated as a string. Access to the string parameters via DDFilteredView get<double> is forbidden: currently a value 0 is returned, further restriction is being implemented to return NaN.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

A new Issue was created by @ianna Ianna Osborne.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Dec 8, 2020

assign geometry

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2020

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@ghugo83
Copy link
Contributor

ghugo83 commented Dec 14, 2020

Ha I see was done here for Phase 1, following recent change in FilteredView: 32a0c74#diff-7302cd669ba77ff993549a7ab094d7feac189f27ed543dd1970d854dd78b3c05
Gonna push a PR for Phase 2 today

@ghugo83
Copy link
Contributor

ghugo83 commented Mar 23, 2021

Can close this issue.
Addressed in #32479 and #32843

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

@qliphy qliphy closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants