-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'PSet' object has no attribute 'btagCMVA' #31768
Comments
A new Issue was created by @silviodonato Silvio Donato. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign xpog |
New categories assigned: xpog @fgolf,@mariadalfonso,@gouskos,@peruzzim you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@alefisico @camclean @andrzejnovak The JMEnano (also used by the BTV) workflows are giving problem. The BTV group is deprecating some of the discriminator for the central nano after the 10_6 and you are adding them for the JMEnano for any potential jets reconstruction Do you really need them in the JME(BTV)nano ? |
I'm taking a look, but CMVA is not supported and I don't know of anyone using it for anything. |
No,we dont need them, we need the default btagging discriminators. Sorry if my comment in #31714 was confusing, what I meant is that we need the default btagging discriminators in all the other jet collections. |
Hi: The CSV discriminant for AK8/AK15 jet collections should be kept [and I think it does not create any errors] since it is used for the calibration of DeepAK8/DeepAK15/ParticleNet |
BTV want to keep the do you really need what is not supported by BTV ? |
Hi @mariadalfonso - Yes this what I wrote keep CSV; CMVA can be removed |
Yes, this checks out. We are removing CMVA, keeping CSVv2. Edit: To clarify, we don't actually support CSVv2 in the sense of providing scale factors, but it's useful for debugging or in the case of DeepAK8 SF derivation. I would expect that once we have PFNano(NanoAODJMAR) better tested, it can be moved there. |
I think the CSVv2 is the main tagger for the EOY still. let's take the experience from the UL analysis first then we review for the Run3 central nano. JMEnano can be adapted after also. There is no reason to have packed candidates occupy twice disk space (one in miniAOD and one in PFNano(NanoAODJMAR), as you see multiplication of nano lead always to errors. |
@andrzejnovak @alefisico @hqucms Two possibilities in any cases the PR should pass let me know how you proceed ? Maria |
@mariadalfonso looks like an easy fix, I'm running the failed WFs now, will submit a PR asap |
After having merged #31618 (
CMSSW_11_2_X_2020-10-13-1100
) we get this error in wf 10224.15, 11024.15, 25202.15The text was updated successfully, but these errors were encountered: