-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracks with ill-defined momenta within pat::PackedCands #31583
Comments
A new Issue was created by @mbluj . @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign xpog |
New categories assigned: xpog @fgolf,@mariadalfonso,@gouskos,@peruzzim you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@bendavid @hatakeyamak @mtosi |
@mariadalfonso |
from #31582 (comment)
|
I think that this issue is a duplicate of #27374 |
It is unlikely a PFCandidate issue as it looks be related to packedCandidates built on top of tracks unused by PFlow (lostTracks). It can be either issue of tracks (with a low quality) or a way in which the tracks are packed into packedCandidate dataformat. To understand origin of the problem one should check original AOD events used to produce MiniAOD ones with problematic cands/tracks (I had not time to check, the original AODs are only on types). Probably the issue is fixed by #27988, but not checked explicitly. |
I see. Thank you. |
Hmm, I am afraid that there is not any equivalent 106X or later sample. I also do not know if big UL MiniAOD samples were produced with or without the fix (in small samples as relvals the issue can be not present because of its rarity). Really, the best thing will be to get the original AOD event (*) check the problematic track and eventually build miniAOD on top of it using 106X with the fix. (*) BTW, do you know if edmPickEvent should work as it is failing for me. |
What is the AOD sample? If it's on tape, we may have to do something extra. |
It is /TauGun_Pt-15to3000_13TeV_pythia8/RunIIAutumn18DRPremix-102X_upgrade2018_realistic_v15-v1/AODSIM on tapes accordingly to DAS. |
Do you know the specific file or block containing this event? If so, I can ask FNAL (T1_US_FNAL) computing folks. |
Unfortunately no. As written above, in principle it can be checked with edmPickEvents.py, but it fails. Namely, I tried:
as advised in https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookPickEvent, but it apparently has problems. |
The relevant file should be on its way to disk to enable pickEvents. |
OK, great, thanks! Please let me know when it is there. Then, I will try to perform relevant checks. |
Sounds good. pickEvent still doesn't work for me, but edmFileUtil -e root://kodiak-se.baylor.edu//store/mc/RunIIAutumn18DRPremix/TauGun_Pt-15to3000_13TeV_pythia8/AODSIM/102X_upgrade2018_realistic_v15-v1/120000/5CE6FB17-A5FB-6843-86F7-C9C276A6AF16.root | grep 1556024 Can you take it from here? |
Yes, thanks. I copied the file locally. |
I performed the checks with the following results:
=> I think it closes the issue. |
Thanks. All sound good. |
Perhaps this can be closed? |
Yes, right. I close it. |
In miniAOD samples (recent 94X/102X productions) there are rare tracks within pat:PackedCandidates (mainly lostTracks collection) with ill-defined momenta, i.e. pt being inf and/or eta nan.
The issue was discovered during big validation of tauReco@Mini and caused its failure. The failures of tauReco@Mini are fixed by protection introduced by #31582, but it was not checked if the ill-defined momenta are feature introduced in creation of pat::PackedCandidates (it can be caused either by compression or forcing a given mass of a candidate) or already original reco::Tracks are affected => probably should be followed up by XPOG.
An example of problematic pat::PackedCandidate can be found in /store/mc/RunIIAutumn18MiniAOD/TauGun_Pt-15to3000_13TeV_pythia8/MINIAODSIM/102X_upgrade2018_realistic_v15-v1/120000/1C5E6BED-FAFA-BC49-AC3C-DDBCC35CBE24.root, Run 1, Event 1556024, LumiSection 1557
The text was updated successfully, but these errors were encountered: