From c71a5893a8dd0316ff5d7f2a0cbcf61d51140728 Mon Sep 17 00:00:00 2001 From: Shahzad Malik Muzaffar Date: Thu, 29 Jul 2021 12:54:36 +0200 Subject: [PATCH 1/2] [Misc2][clang-tidy] make deleted function public --- .../interface/ESTrivialConditionRetriever.h | 5 ++--- .../interface/EcalTrivialConditionRetriever.h | 5 ++--- .../HcalTPGAlgos/interface/XMLProcessor.h | 4 ++-- .../interface/Phase2TrackerCablingESProducer.h | 5 ++--- .../interface/SiStripGainESSource.h | 5 ++--- .../interface/SiStripNoiseESSource.h | 5 ++--- .../interface/SiStripPedestalsESSource.h | 5 ++--- .../plugins/fake/SiStripTemplateEmptyFakeESSource.h | 5 ++--- .../HcalOnlineDb/interface/XMLLUTLoader.h | 7 ++----- .../interface/SiStripCommissioningSource.h | 7 ++++--- .../plugins/tracking/SiStripFineDelayTOF.h | 3 ++- DQM/SiStripCommon/interface/SiStripHistoId.h | 4 ++-- DQMOffline/Trigger/interface/EgHLTOffHelper.h | 6 ++---- DQMOffline/Trigger/interface/EgHLTOfflineSource.h | 5 +++-- DQMServices/FwkIO/plugins/DQMRootSource.cc | 7 +++---- EventFilter/GctRawToDigi/src/GctUnpackCollections.h | 8 ++++---- .../plugins/implementations_stage2/UCTCTP7RawData.h | 9 ++++----- EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h | 10 +++++----- EventFilter/L1TXRawToDigi/interface/UCTCTP7RawData.h | 9 ++++----- EventFilter/L1TXRawToDigi/interface/UCTDAQRawData.h | 9 ++++----- EventFilter/RctRawToDigi/src/RctUnpackCollections.h | 8 ++++---- .../plugins/SiStripRawToDigiUnpacker.h | 6 +++--- .../Herwig7Interface/interface/Proxy.h | 8 ++++---- .../HiGenCommon/plugins/BetaBoostEvtVtxGenerator.cc | 9 ++++----- .../HiGenCommon/plugins/MixBoostEvtVtxGenerator.cc | 9 ++++----- GeneratorInterface/LHEInterface/interface/LHEProxy.h | 8 ++++---- GeneratorInterface/LHEInterface/src/XMLUtils.h | 5 ++--- .../interface/XMLIdealGeometryESSource.h | 4 ++-- .../interface/BeamProfileVtxGenerator.h | 10 ++++------ .../interface/BetafuncEvtVtxGenerator.h | 9 ++++----- .../interface/FlatEvtVtxGenerator.h | 10 ++++------ .../interface/GaussEvtVtxGenerator.h | 10 ++++------ .../interface/HLLHCEvtVtxGenerator.h | 12 ++++++------ IOPool/Output/src/RootOutputTree.cc | 4 ++-- 34 files changed, 106 insertions(+), 129 deletions(-) diff --git a/CalibCalorimetry/EcalTrivialCondModules/interface/ESTrivialConditionRetriever.h b/CalibCalorimetry/EcalTrivialCondModules/interface/ESTrivialConditionRetriever.h index 12e6cf0f2c3ac..24509e705f79e 100644 --- a/CalibCalorimetry/EcalTrivialCondModules/interface/ESTrivialConditionRetriever.h +++ b/CalibCalorimetry/EcalTrivialCondModules/interface/ESTrivialConditionRetriever.h @@ -40,6 +40,8 @@ namespace edm { class ESTrivialConditionRetriever : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: ESTrivialConditionRetriever(const edm::ParameterSet& pset); + ESTrivialConditionRetriever(const ESTrivialConditionRetriever&) = delete; // stop default + const ESTrivialConditionRetriever& operator=(const ESTrivialConditionRetriever&) = delete; // stop default ~ESTrivialConditionRetriever() override; // ---------- member functions --------------------------- @@ -64,9 +66,6 @@ class ESTrivialConditionRetriever : public edm::ESProducer, public edm::EventSet edm::ValidityInterval&) override; private: - ESTrivialConditionRetriever(const ESTrivialConditionRetriever&) = delete; // stop default - const ESTrivialConditionRetriever& operator=(const ESTrivialConditionRetriever&) = delete; // stop default - void getWeightsFromConfiguration(const edm::ParameterSet& ps); // data members diff --git a/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h b/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h index 543e98eaf2b3d..0f9e0c6f9b804 100644 --- a/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h +++ b/CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h @@ -123,6 +123,8 @@ namespace edm { class EcalTrivialConditionRetriever : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: EcalTrivialConditionRetriever(const edm::ParameterSet& pset); + EcalTrivialConditionRetriever(const EcalTrivialConditionRetriever&) = delete; // stop default + const EcalTrivialConditionRetriever& operator=(const EcalTrivialConditionRetriever&) = delete; // stop default ~EcalTrivialConditionRetriever() override; // ---------- member functions --------------------------- @@ -202,9 +204,6 @@ class EcalTrivialConditionRetriever : public edm::ESProducer, public edm::EventS edm::ValidityInterval&) override; private: - EcalTrivialConditionRetriever(const EcalTrivialConditionRetriever&) = delete; // stop default - const EcalTrivialConditionRetriever& operator=(const EcalTrivialConditionRetriever&) = delete; // stop default - void getWeightsFromConfiguration(const edm::ParameterSet& ps); // data members diff --git a/CalibCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h b/CalibCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h index 61338801b6a32..79e5c01f0f95a 100644 --- a/CalibCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h +++ b/CalibCalorimetry/HcalTPGAlgos/interface/XMLProcessor.h @@ -137,6 +137,8 @@ class XMLProcessor { return instance; } + XMLProcessor(const XMLProcessor&) = delete; // stop default + // returns XML std::string if target == "string" otherwise NULL XMLCh* serializeDOM(XERCES_CPP_NAMESPACE::DOMNode* node, std::string target = "stdout"); @@ -161,8 +163,6 @@ class XMLProcessor { private: XMLProcessor(); - XMLProcessor(const XMLProcessor&) = delete; // stop default - //const XMLProcessor& operator=(const XMLProcessor&); // stop default // ---------- member data -------------------------------- diff --git a/CalibTracker/SiStripESProducers/interface/Phase2TrackerCablingESProducer.h b/CalibTracker/SiStripESProducers/interface/Phase2TrackerCablingESProducer.h index e0b89516b7d21..8591f09b4ece2 100644 --- a/CalibTracker/SiStripESProducers/interface/Phase2TrackerCablingESProducer.h +++ b/CalibTracker/SiStripESProducers/interface/Phase2TrackerCablingESProducer.h @@ -11,14 +11,13 @@ class Phase2TrackerCablingRcd; class Phase2TrackerCablingESProducer : public edm::ESProducer { public: Phase2TrackerCablingESProducer(const edm::ParameterSet&); + Phase2TrackerCablingESProducer(const Phase2TrackerCablingESProducer&) = delete; + const Phase2TrackerCablingESProducer& operator=(const Phase2TrackerCablingESProducer&) = delete; ~Phase2TrackerCablingESProducer() override; virtual std::unique_ptr produce(const Phase2TrackerCablingRcd&); private: - Phase2TrackerCablingESProducer(const Phase2TrackerCablingESProducer&) = delete; - const Phase2TrackerCablingESProducer& operator=(const Phase2TrackerCablingESProducer&) = delete; - virtual Phase2TrackerCabling* make(const Phase2TrackerCablingRcd&) = 0; }; diff --git a/CalibTracker/SiStripESProducers/interface/SiStripGainESSource.h b/CalibTracker/SiStripESProducers/interface/SiStripGainESSource.h index add2fec8f5096..a8f7eaa5902c5 100644 --- a/CalibTracker/SiStripESProducers/interface/SiStripGainESSource.h +++ b/CalibTracker/SiStripESProducers/interface/SiStripGainESSource.h @@ -17,6 +17,8 @@ class SiStripApvGainRcd; class SiStripGainESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: SiStripGainESSource(const edm::ParameterSet&); + SiStripGainESSource(const SiStripGainESSource&) = delete; + const SiStripGainESSource& operator=(const SiStripGainESSource&) = delete; ~SiStripGainESSource() override { ; } virtual std::unique_ptr produce(const SiStripApvGainRcd&); @@ -27,9 +29,6 @@ class SiStripGainESSource : public edm::ESProducer, public edm::EventSetupRecord edm::ValidityInterval&) override; private: - SiStripGainESSource(const SiStripGainESSource&) = delete; - const SiStripGainESSource& operator=(const SiStripGainESSource&) = delete; - virtual SiStripApvGain* makeGain() = 0; }; diff --git a/CalibTracker/SiStripESProducers/interface/SiStripNoiseESSource.h b/CalibTracker/SiStripESProducers/interface/SiStripNoiseESSource.h index a480b4dac586c..cda60fac77199 100644 --- a/CalibTracker/SiStripESProducers/interface/SiStripNoiseESSource.h +++ b/CalibTracker/SiStripESProducers/interface/SiStripNoiseESSource.h @@ -17,6 +17,8 @@ class SiStripNoisesRcd; class SiStripNoiseESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: SiStripNoiseESSource(const edm::ParameterSet&); + SiStripNoiseESSource(const SiStripNoiseESSource&) = delete; + const SiStripNoiseESSource& operator=(const SiStripNoiseESSource&) = delete; ~SiStripNoiseESSource() override { ; } virtual std::unique_ptr produce(const SiStripNoisesRcd&); @@ -27,9 +29,6 @@ class SiStripNoiseESSource : public edm::ESProducer, public edm::EventSetupRecor edm::ValidityInterval&) override; private: - SiStripNoiseESSource(const SiStripNoiseESSource&) = delete; - const SiStripNoiseESSource& operator=(const SiStripNoiseESSource&) = delete; - virtual SiStripNoises* makeNoise() = 0; }; diff --git a/CalibTracker/SiStripESProducers/interface/SiStripPedestalsESSource.h b/CalibTracker/SiStripESProducers/interface/SiStripPedestalsESSource.h index 2f08b043af286..94e14064d3162 100644 --- a/CalibTracker/SiStripESProducers/interface/SiStripPedestalsESSource.h +++ b/CalibTracker/SiStripESProducers/interface/SiStripPedestalsESSource.h @@ -17,6 +17,8 @@ class SiStripPedestalsRcd; class SiStripPedestalsESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: SiStripPedestalsESSource(const edm::ParameterSet&); + SiStripPedestalsESSource(const SiStripPedestalsESSource&) = delete; + const SiStripPedestalsESSource& operator=(const SiStripPedestalsESSource&) = delete; ~SiStripPedestalsESSource() override { ; } virtual std::unique_ptr produce(const SiStripPedestalsRcd&); @@ -27,9 +29,6 @@ class SiStripPedestalsESSource : public edm::ESProducer, public edm::EventSetupR edm::ValidityInterval&) override; private: - SiStripPedestalsESSource(const SiStripPedestalsESSource&) = delete; - const SiStripPedestalsESSource& operator=(const SiStripPedestalsESSource&) = delete; - virtual SiStripPedestals* makePedestals() = 0; }; diff --git a/CalibTracker/SiStripESProducers/plugins/fake/SiStripTemplateEmptyFakeESSource.h b/CalibTracker/SiStripESProducers/plugins/fake/SiStripTemplateEmptyFakeESSource.h index 5858caed9f260..d01290de1bdba 100644 --- a/CalibTracker/SiStripESProducers/plugins/fake/SiStripTemplateEmptyFakeESSource.h +++ b/CalibTracker/SiStripESProducers/plugins/fake/SiStripTemplateEmptyFakeESSource.h @@ -20,6 +20,8 @@ template class SiStripTemplateEmptyFakeESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: SiStripTemplateEmptyFakeESSource(const edm::ParameterSet&); + SiStripTemplateEmptyFakeESSource(const SiStripTemplateEmptyFakeESSource&) = delete; + const SiStripTemplateEmptyFakeESSource& operator=(const SiStripTemplateEmptyFakeESSource&) = delete; ~SiStripTemplateEmptyFakeESSource() override{}; std::unique_ptr produce(const TRecord&); @@ -28,9 +30,6 @@ class SiStripTemplateEmptyFakeESSource : public edm::ESProducer, public edm::Eve void setIntervalFor(const edm::eventsetup::EventSetupRecordKey&, const edm::IOVSyncValue& iov, edm::ValidityInterval& iValidity) override; - - SiStripTemplateEmptyFakeESSource(const SiStripTemplateEmptyFakeESSource&) = delete; - const SiStripTemplateEmptyFakeESSource& operator=(const SiStripTemplateEmptyFakeESSource&) = delete; }; template diff --git a/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h b/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h index 7619921211b0c..bbae10c425321 100644 --- a/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h +++ b/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h @@ -50,6 +50,8 @@ class XMLLUTLoader : public XMLDOMBlock { XMLLUTLoader(); XMLLUTLoader(XMLProcessor::loaderBaseConfig* config, std::string templateBase = "HCAL_TRIG_PRIM_LOOKUP_TABLE.XMLloader.template"); + XMLLUTLoader(const XMLLUTLoader&) = delete; // stop default + const XMLLUTLoader& operator=(const XMLLUTLoader&) = delete; // stop default ~XMLLUTLoader() override; int addLUT(lutDBConfig* config, std::string templateFileName = "HCAL_TRIG_PRIM_LOOKUP_TABLE.dataset.template"); @@ -58,11 +60,6 @@ class XMLLUTLoader : public XMLDOMBlock { std::string templateFileName = "HCAL_TRIG_PRIM_LOOKUP_TABLE.checksums.template"); int createLoader(const std::vector& crate_number, const std::vector& file_name); - -private: - XMLLUTLoader(const XMLLUTLoader&) = delete; // stop default - - const XMLLUTLoader& operator=(const XMLLUTLoader&) = delete; // stop default }; #endif diff --git a/DQM/SiStripCommissioningSources/interface/SiStripCommissioningSource.h b/DQM/SiStripCommissioningSources/interface/SiStripCommissioningSource.h index 48ff8d6dee355..040c85a807909 100644 --- a/DQM/SiStripCommissioningSources/interface/SiStripCommissioningSource.h +++ b/DQM/SiStripCommissioningSources/interface/SiStripCommissioningSource.h @@ -41,6 +41,10 @@ class SiStripCommissioningSource : public edm::EDAnalyzer { typedef dqm::legacy::MonitorElement MonitorElement; SiStripCommissioningSource(const edm::ParameterSet&); + + /** Private default constructor. */ + SiStripCommissioningSource() = delete; + ~SiStripCommissioningSource() override; void beginRun(edm::Run const&, const edm::EventSetup&) override; @@ -48,9 +52,6 @@ class SiStripCommissioningSource : public edm::EDAnalyzer { void endJob() override; private: // ---------- Private methods ---------- - /** Private default constructor. */ - SiStripCommissioningSource() = delete; - /** */ DQMStore* const dqm(std::string method = "") const; diff --git a/DQM/SiStripCommissioningSources/plugins/tracking/SiStripFineDelayTOF.h b/DQM/SiStripCommissioningSources/plugins/tracking/SiStripFineDelayTOF.h index b4dd8dbac1cca..76124587b906b 100644 --- a/DQM/SiStripCommissioningSources/plugins/tracking/SiStripFineDelayTOF.h +++ b/DQM/SiStripCommissioningSources/plugins/tracking/SiStripFineDelayTOF.h @@ -12,9 +12,10 @@ class SiStripFineDelayTOF { static double timeOfFlight(bool cosmics, bool field, double* trackParameters, double* hit, double* phit, bool onDisk); static void trackParameters(const reco::Track& tk, double* trackParameters); -private: SiStripFineDelayTOF() = delete; virtual ~SiStripFineDelayTOF() = delete; + +private: static double timeOfFlightCosmic(double* hit, double* phit); static double timeOfFlightCosmicB(double* trackParameters, double* hit, double* phit, bool onDisk); static double timeOfFlightBeam(double* hit, double* phit); diff --git a/DQM/SiStripCommon/interface/SiStripHistoId.h b/DQM/SiStripCommon/interface/SiStripHistoId.h index ab5e9a1179537..e4d6cf5d4a6bd 100644 --- a/DQM/SiStripCommon/interface/SiStripHistoId.h +++ b/DQM/SiStripCommon/interface/SiStripHistoId.h @@ -25,6 +25,8 @@ class TrackerTopology; class SiStripHistoId { public: SiStripHistoId(); + SiStripHistoId(const SiStripHistoId&) = delete; // stop default + const SiStripHistoId& operator=(const SiStripHistoId&) = delete; // stop default virtual ~SiStripHistoId(); // generally: histoid = description + separator1 + id_type + separator2 + component_id std::string createHistoId(std::string description, std::string id_type, uint32_t component_id); @@ -36,8 +38,6 @@ class SiStripHistoId { std::string getComponentType(std::string histoid); private: - SiStripHistoId(const SiStripHistoId&) = delete; // stop default - const SiStripHistoId& operator=(const SiStripHistoId&) = delete; // stop default std::string returnIdPart(std::string histoid, uint32_t whichpart); }; diff --git a/DQMOffline/Trigger/interface/EgHLTOffHelper.h b/DQMOffline/Trigger/interface/EgHLTOffHelper.h index ab4dbc4270fa2..8dd397fdcdd62 100644 --- a/DQMOffline/Trigger/interface/EgHLTOffHelper.h +++ b/DQMOffline/Trigger/interface/EgHLTOffHelper.h @@ -157,10 +157,6 @@ namespace egHLT { std::vector trigCutParams_; //probably the least bad option - private: //disabling copy / assignment - OffHelper& operator=(const OffHelper&) = delete; - OffHelper(const OffHelper&) = delete; - public: OffHelper() : eleLooseCuts_(), @@ -169,6 +165,8 @@ namespace egHLT { phoCuts_(), hltEleTrkIsolAlgo_(nullptr), hltPhoTrkIsolAlgo_(nullptr) {} + OffHelper& operator=(const OffHelper&) = delete; + OffHelper(const OffHelper&) = delete; ~OffHelper(); void setup(const edm::ParameterSet& conf, edm::ConsumesCollector&& iC); diff --git a/DQMOffline/Trigger/interface/EgHLTOfflineSource.h b/DQMOffline/Trigger/interface/EgHLTOfflineSource.h index f20fb5fcce277..5bac6381138b6 100644 --- a/DQMOffline/Trigger/interface/EgHLTOfflineSource.h +++ b/DQMOffline/Trigger/interface/EgHLTOfflineSource.h @@ -93,12 +93,13 @@ class EgHLTOfflineSource : public DQMEDAnalyzer { bool filterInactiveTriggers_; std::string hltTag_; +public: + explicit EgHLTOfflineSource(const edm::ParameterSet&); + //disabling copying/assignment (copying this class would be bad, mkay) EgHLTOfflineSource(const EgHLTOfflineSource& rhs) = delete; EgHLTOfflineSource& operator=(const EgHLTOfflineSource& rhs) = delete; -public: - explicit EgHLTOfflineSource(const edm::ParameterSet&); ~EgHLTOfflineSource() override; void bookHistograms(DQMStore::IBooker&, edm::Run const&, edm::EventSetup const&) override; diff --git a/DQMServices/FwkIO/plugins/DQMRootSource.cc b/DQMServices/FwkIO/plugins/DQMRootSource.cc index 73e1cf080b36f..bb3b7710f510a 100644 --- a/DQMServices/FwkIO/plugins/DQMRootSource.cc +++ b/DQMServices/FwkIO/plugins/DQMRootSource.cc @@ -311,18 +311,19 @@ struct DQMTTreeIO { class DQMRootSource : public edm::PuttableSourceBase, DQMTTreeIO { public: DQMRootSource(edm::ParameterSet const&, const edm::InputSourceDescription&); + DQMRootSource(const DQMRootSource&) = delete; ~DQMRootSource() override; // ---------- const member functions --------------------- + const DQMRootSource& operator=(const DQMRootSource&) = delete; // stop default + // ---------- static member functions -------------------- // ---------- member functions --------------------------- static void fillDescriptions(edm::ConfigurationDescriptions& descriptions); private: - DQMRootSource(const DQMRootSource&) = delete; - edm::InputSource::ItemType getNextItemType() override; std::shared_ptr readFile_() override; @@ -353,8 +354,6 @@ class DQMRootSource : public edm::PuttableSourceBase, DQMTTreeIO { bool keepIt(edm::RunNumber_t, edm::LuminosityBlockNumber_t) const; void logFileAction(char const* msg, char const* fileName) const; - const DQMRootSource& operator=(const DQMRootSource&) = delete; // stop default - // ---------- member data -------------------------------- // Properties from python config diff --git a/EventFilter/GctRawToDigi/src/GctUnpackCollections.h b/EventFilter/GctRawToDigi/src/GctUnpackCollections.h index f2d34c8274bb7..f980f757dc31a 100644 --- a/EventFilter/GctRawToDigi/src/GctUnpackCollections.h +++ b/EventFilter/GctRawToDigi/src/GctUnpackCollections.h @@ -23,6 +23,10 @@ class GctUnpackCollections { /// Construct with an event. The collections get put into the event when the object instance goes out of scope (i.e. in the destructor). GctUnpackCollections(edm::Event& event); + /// deliberately not implemented! + GctUnpackCollections(const GctUnpackCollections&) = delete; ///< Copy ctor + GctUnpackCollections& operator=(const GctUnpackCollections&) = delete; ///< Assignment op + /// Destructor - the last action of this object is to put the gct collections into the event provided on construction. ~GctUnpackCollections(); @@ -84,10 +88,6 @@ class GctUnpackCollections { L1TriggerErrorCollection* const errors() const { return m_errors.get(); } ///< Unpack error code collection. private: - GctUnpackCollections(const GctUnpackCollections&) = delete; ///< Copy ctor - deliberately not implemented! - GctUnpackCollections& operator=(const GctUnpackCollections&) = - delete; ///< Assignment op - deliberately not implemented! - edm::Event& m_event; ///< The event the collections will be put into on destruction of the GctUnpackCollections instance. diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/UCTCTP7RawData.h b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/UCTCTP7RawData.h index 3c8e6650056af..c8a859858bbfb 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/UCTCTP7RawData.h +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/UCTCTP7RawData.h @@ -21,6 +21,10 @@ class UCTCTP7RawData { } } + // No copy constructor and equality operator are needed + UCTCTP7RawData(const UCTCTP7RawData&) = delete; + const UCTCTP7RawData& operator=(const UCTCTP7RawData& i) = delete; + virtual ~UCTCTP7RawData() { ; } // Access functions for convenience @@ -333,11 +337,6 @@ class UCTCTP7RawData { } private: - // No copy constructor and equality operator are needed - - UCTCTP7RawData(const UCTCTP7RawData&) = delete; - const UCTCTP7RawData& operator=(const UCTCTP7RawData& i) = delete; - // Pointer to contiguous array of 192 values // We assume instantiator of this class will gurantee that fact const uint32_t* myDataPtr; diff --git a/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h b/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h index 77e555e4ff4f8..1b8a5027d817e 100644 --- a/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h +++ b/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h @@ -5,6 +5,11 @@ class UCTAMCRawData { public: UCTAMCRawData(const uint32_t *d) : myDataPtr(d) {} + // No copy constructor and equality operator are needed + UCTAMCRawData(const UCTAMCRawData &) = delete; + const UCTAMCRawData &operator=(const UCTAMCRawData &i) = delete; + + virtual ~UCTAMCRawData() { ; } // Access functions for convenience @@ -45,11 +50,6 @@ class UCTAMCRawData { } private: - // No copy constructor and equality operator are needed - - UCTAMCRawData(const UCTAMCRawData &) = delete; - const UCTAMCRawData &operator=(const UCTAMCRawData &i) = delete; - // RawData data const uint32_t *myDataPtr; diff --git a/EventFilter/L1TXRawToDigi/interface/UCTCTP7RawData.h b/EventFilter/L1TXRawToDigi/interface/UCTCTP7RawData.h index 7968c6f2dc2fa..f82afc2044c20 100644 --- a/EventFilter/L1TXRawToDigi/interface/UCTCTP7RawData.h +++ b/EventFilter/L1TXRawToDigi/interface/UCTCTP7RawData.h @@ -16,6 +16,10 @@ class UCTCTP7RawData { } } + // No copy constructor and equality operator are needed + UCTCTP7RawData(const UCTCTP7RawData&) = delete; + const UCTCTP7RawData& operator=(const UCTCTP7RawData& i) = delete; + virtual ~UCTCTP7RawData() { ; } // Access functions for convenience @@ -330,11 +334,6 @@ class UCTCTP7RawData { } private: - // No copy constructor and equality operator are needed - - UCTCTP7RawData(const UCTCTP7RawData&) = delete; - const UCTCTP7RawData& operator=(const UCTCTP7RawData& i) = delete; - // RawData data const uint32_t* myDataPtr; diff --git a/EventFilter/L1TXRawToDigi/interface/UCTDAQRawData.h b/EventFilter/L1TXRawToDigi/interface/UCTDAQRawData.h index 02970a9e8f912..eb2585878b856 100644 --- a/EventFilter/L1TXRawToDigi/interface/UCTDAQRawData.h +++ b/EventFilter/L1TXRawToDigi/interface/UCTDAQRawData.h @@ -20,6 +20,10 @@ class UCTDAQRawData { } } + // No copy constructor and equality operator are needed + UCTDAQRawData(const UCTDAQRawData &) = delete; + const UCTDAQRawData &operator=(const UCTDAQRawData &i) = delete; + virtual ~UCTDAQRawData() { ; } // Access functions for convenience @@ -279,11 +283,6 @@ class UCTDAQRawData { } private: - // No copy constructor and equality operator are needed - - UCTDAQRawData(const UCTDAQRawData &) = delete; - const UCTDAQRawData &operator=(const UCTDAQRawData &i) = delete; - // RawData data const uint64_t *myDataPtr; diff --git a/EventFilter/RctRawToDigi/src/RctUnpackCollections.h b/EventFilter/RctRawToDigi/src/RctUnpackCollections.h index 66d628559296b..169d131225b08 100644 --- a/EventFilter/RctRawToDigi/src/RctUnpackCollections.h +++ b/EventFilter/RctRawToDigi/src/RctUnpackCollections.h @@ -20,6 +20,10 @@ class RctUnpackCollections { /// Construct with an event. The collections get put into the event when the object instance goes out of scope (i.e. in the destructor). RctUnpackCollections(edm::Event& event); + /// deliberately not implemented! + RctUnpackCollections(const RctUnpackCollections&) = delete; ///< Copy ctor + RctUnpackCollections& operator=(const RctUnpackCollections&) = delete; ///< Assignment op + /// Destructor - the last action of this object is to put the rct collections into the event provided on construction. ~RctUnpackCollections(); @@ -30,10 +34,6 @@ class RctUnpackCollections { } ///< Input calo regions from the RCT to the RCT. private: - RctUnpackCollections(const RctUnpackCollections&) = delete; ///< Copy ctor - deliberately not implemented! - RctUnpackCollections& operator=(const RctUnpackCollections&) = - delete; ///< Assignment op - deliberately not implemented! - edm::Event& m_event; ///< The event the collections will be put into on destruction of the RctUnpackCollections instance. diff --git a/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiUnpacker.h b/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiUnpacker.h index e223216950211..b9251af3b277b 100644 --- a/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiUnpacker.h +++ b/EventFilter/SiStripRawToDigi/plugins/SiStripRawToDigiUnpacker.h @@ -45,6 +45,9 @@ namespace sistrip { bool mark_missing_feds, const uint32_t errorThreshold); + /// private default constructor + RawToDigiUnpacker() = delete; + /// default constructor ~RawToDigiUnpacker(); @@ -86,9 +89,6 @@ namespace sistrip { void update( RawDigis& scope_mode, RawDigis& virgin_raw, RawDigis& proc_raw, Digis& zero_suppr, RawDigis& common_mode); - /// private default constructor - RawToDigiUnpacker() = delete; - /// sets the SiStripEventSummary -> not yet implemented for FEDBuffer class void updateEventSummary(const sistrip::FEDBuffer&, SiStripEventSummary&); diff --git a/GeneratorInterface/Herwig7Interface/interface/Proxy.h b/GeneratorInterface/Herwig7Interface/interface/Proxy.h index c02ce01b9202c..293c28699e926 100644 --- a/GeneratorInterface/Herwig7Interface/interface/Proxy.h +++ b/GeneratorInterface/Herwig7Interface/interface/Proxy.h @@ -15,6 +15,10 @@ namespace ThePEG { public: typedef unsigned long ProxyID; + // not allowed and not implemented + ProxyBase(const ProxyBase &orig) = delete; + ProxyBase &operator=(const ProxyBase &orig) = delete; + virtual ~ProxyBase(); ProxyID getID() const { return id; } @@ -30,10 +34,6 @@ namespace ThePEG { static std::shared_ptr create(ctor_t ctor); static std::shared_ptr find(ProxyID id); - // not allowed and not implemented - ProxyBase(const ProxyBase &orig) = delete; - ProxyBase &operator=(const ProxyBase &orig) = delete; - const ProxyID id; }; diff --git a/GeneratorInterface/HiGenCommon/plugins/BetaBoostEvtVtxGenerator.cc b/GeneratorInterface/HiGenCommon/plugins/BetaBoostEvtVtxGenerator.cc index be987a7200b55..c6bd8f7f2015e 100644 --- a/GeneratorInterface/HiGenCommon/plugins/BetaBoostEvtVtxGenerator.cc +++ b/GeneratorInterface/HiGenCommon/plugins/BetaBoostEvtVtxGenerator.cc @@ -52,6 +52,10 @@ namespace CLHEP { class BetaBoostEvtVtxGenerator : public edm::EDProducer { public: BetaBoostEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + BetaBoostEvtVtxGenerator(const BetaBoostEvtVtxGenerator& p) = delete; + /** Copy assignment operator */ + BetaBoostEvtVtxGenerator& operator=(const BetaBoostEvtVtxGenerator& rhs) = delete; ~BetaBoostEvtVtxGenerator() override; /// return a new event vertex @@ -85,11 +89,6 @@ class BetaBoostEvtVtxGenerator : public edm::EDProducer { double BetaFunction(double z, double z0); private: - /** Copy constructor */ - BetaBoostEvtVtxGenerator(const BetaBoostEvtVtxGenerator& p) = delete; - /** Copy assignment operator */ - BetaBoostEvtVtxGenerator& operator=(const BetaBoostEvtVtxGenerator& rhs) = delete; - double alpha_, phi_; //TMatrixD boost_; double beta_; diff --git a/GeneratorInterface/HiGenCommon/plugins/MixBoostEvtVtxGenerator.cc b/GeneratorInterface/HiGenCommon/plugins/MixBoostEvtVtxGenerator.cc index 3094bc4f34d30..12cc0b139dc9e 100644 --- a/GeneratorInterface/HiGenCommon/plugins/MixBoostEvtVtxGenerator.cc +++ b/GeneratorInterface/HiGenCommon/plugins/MixBoostEvtVtxGenerator.cc @@ -50,6 +50,10 @@ class FourVector; class MixBoostEvtVtxGenerator : public edm::EDProducer { public: MixBoostEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + MixBoostEvtVtxGenerator(const MixBoostEvtVtxGenerator& p) = delete; + /** Copy assignment operator */ + MixBoostEvtVtxGenerator& operator=(const MixBoostEvtVtxGenerator& rhs) = delete; ~MixBoostEvtVtxGenerator() override; /// return a new event vertex @@ -83,11 +87,6 @@ class MixBoostEvtVtxGenerator : public edm::EDProducer { double BetaFunction(double z, double z0); private: - /** Copy constructor */ - MixBoostEvtVtxGenerator(const MixBoostEvtVtxGenerator& p) = delete; - /** Copy assignment operator */ - MixBoostEvtVtxGenerator& operator=(const MixBoostEvtVtxGenerator& rhs) = delete; - double alpha_, phi_; //TMatrixD boost_; double beta_; diff --git a/GeneratorInterface/LHEInterface/interface/LHEProxy.h b/GeneratorInterface/LHEInterface/interface/LHEProxy.h index 3b06ca0644749..f29521139d8ce 100644 --- a/GeneratorInterface/LHEInterface/interface/LHEProxy.h +++ b/GeneratorInterface/LHEInterface/interface/LHEProxy.h @@ -13,6 +13,10 @@ namespace lhef { public: typedef unsigned long ProxyID; + // not allowed and not implemented + LHEProxy(const LHEProxy &orig) = delete; + LHEProxy &operator=(const LHEProxy &orig) = delete; + ~LHEProxy(); const std::shared_ptr &getRunInfo() const { return runInfo; } @@ -43,10 +47,6 @@ namespace lhef { private: LHEProxy(ProxyID id); - // not allowed and not implemented - LHEProxy(const LHEProxy &orig) = delete; - LHEProxy &operator=(const LHEProxy &orig) = delete; - const ProxyID id; std::shared_ptr runInfo; diff --git a/GeneratorInterface/LHEInterface/src/XMLUtils.h b/GeneratorInterface/LHEInterface/src/XMLUtils.h index 1753699a4af85..aae4a1cdce9ab 100644 --- a/GeneratorInterface/LHEInterface/src/XMLUtils.h +++ b/GeneratorInterface/LHEInterface/src/XMLUtils.h @@ -48,13 +48,12 @@ namespace lhef { class XercesPlatform { public: XercesPlatform(); - ~XercesPlatform(); - - private: // do not make any kind of copies XercesPlatform(const XercesPlatform &orig) = delete; XercesPlatform &operator=(const XercesPlatform &orig) = delete; + ~XercesPlatform(); + private: static unsigned int instances; }; diff --git a/GeometryReaders/XMLIdealGeometryESSource/interface/XMLIdealGeometryESSource.h b/GeometryReaders/XMLIdealGeometryESSource/interface/XMLIdealGeometryESSource.h index 412761adec188..7bd01420bd1ab 100644 --- a/GeometryReaders/XMLIdealGeometryESSource/interface/XMLIdealGeometryESSource.h +++ b/GeometryReaders/XMLIdealGeometryESSource/interface/XMLIdealGeometryESSource.h @@ -16,6 +16,8 @@ class XMLIdealGeometryESSource : public edm::ESProducer, public edm::EventSetupRecordIntervalFinder { public: XMLIdealGeometryESSource(const edm::ParameterSet &p); + XMLIdealGeometryESSource(const XMLIdealGeometryESSource &) = delete; + const XMLIdealGeometryESSource &operator=(const XMLIdealGeometryESSource &) = delete; ~XMLIdealGeometryESSource() override; std::unique_ptr produceGeom(const IdealGeometryRecord &); std::unique_ptr produceMagField(const IdealMagneticFieldRecord &); @@ -25,8 +27,6 @@ class XMLIdealGeometryESSource : public edm::ESProducer, public edm::EventSetupR void setIntervalFor(const edm::eventsetup::EventSetupRecordKey &, const edm::IOVSyncValue &, edm::ValidityInterval &) override; - XMLIdealGeometryESSource(const XMLIdealGeometryESSource &) = delete; - const XMLIdealGeometryESSource &operator=(const XMLIdealGeometryESSource &) = delete; private: std::string rootNodeName_; diff --git a/IOMC/EventVertexGenerators/interface/BeamProfileVtxGenerator.h b/IOMC/EventVertexGenerators/interface/BeamProfileVtxGenerator.h index fed56fc0a8da3..d952a5c79b4ae 100644 --- a/IOMC/EventVertexGenerators/interface/BeamProfileVtxGenerator.h +++ b/IOMC/EventVertexGenerators/interface/BeamProfileVtxGenerator.h @@ -19,6 +19,10 @@ namespace CLHEP { class BeamProfileVtxGenerator : public BaseEvtVtxGenerator { public: BeamProfileVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + BeamProfileVtxGenerator(const BeamProfileVtxGenerator& p) = delete; + /** Copy assignment operator */ + BeamProfileVtxGenerator& operator=(const BeamProfileVtxGenerator& rhs) = delete; ~BeamProfileVtxGenerator() override; /// return a new event vertex @@ -48,12 +52,6 @@ class BeamProfileVtxGenerator : public BaseEvtVtxGenerator { /// set type void setType(bool m = true); -private: - /** Copy constructor */ - BeamProfileVtxGenerator(const BeamProfileVtxGenerator& p) = delete; - /** Copy assignment operator */ - BeamProfileVtxGenerator& operator=(const BeamProfileVtxGenerator& rhs) = delete; - private: double fSigmaX, fSigmaY; double fMeanX, fMeanY, fMeanZ; diff --git a/IOMC/EventVertexGenerators/interface/BetafuncEvtVtxGenerator.h b/IOMC/EventVertexGenerators/interface/BetafuncEvtVtxGenerator.h index 8c3a38fcc12cd..803a35ff10558 100644 --- a/IOMC/EventVertexGenerators/interface/BetafuncEvtVtxGenerator.h +++ b/IOMC/EventVertexGenerators/interface/BetafuncEvtVtxGenerator.h @@ -31,6 +31,10 @@ namespace CLHEP { class BetafuncEvtVtxGenerator : public BaseEvtVtxGenerator { public: BetafuncEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + BetafuncEvtVtxGenerator(const BetafuncEvtVtxGenerator& p) = delete; + /** Copy assignment operator */ + BetafuncEvtVtxGenerator& operator=(const BetafuncEvtVtxGenerator& rhs) = delete; ~BetafuncEvtVtxGenerator() override; void beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&) override; @@ -60,11 +64,6 @@ class BetafuncEvtVtxGenerator : public BaseEvtVtxGenerator { double BetaFunction(double z, double z0) const; private: - /** Copy constructor */ - BetafuncEvtVtxGenerator(const BetafuncEvtVtxGenerator& p) = delete; - /** Copy assignment operator */ - BetafuncEvtVtxGenerator& operator=(const BetafuncEvtVtxGenerator& rhs) = delete; - void setBoost(double alpha, double phi); private: diff --git a/IOMC/EventVertexGenerators/interface/FlatEvtVtxGenerator.h b/IOMC/EventVertexGenerators/interface/FlatEvtVtxGenerator.h index 1916cee36cf28..25a976a4e8b3f 100644 --- a/IOMC/EventVertexGenerators/interface/FlatEvtVtxGenerator.h +++ b/IOMC/EventVertexGenerators/interface/FlatEvtVtxGenerator.h @@ -22,6 +22,10 @@ namespace CLHEP { class FlatEvtVtxGenerator : public BaseEvtVtxGenerator { public: FlatEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + FlatEvtVtxGenerator(const FlatEvtVtxGenerator& p) = delete; + /** Copy assignment operator */ + FlatEvtVtxGenerator& operator=(const FlatEvtVtxGenerator& rhs) = delete; ~FlatEvtVtxGenerator() override; /// return a new event vertex @@ -44,12 +48,6 @@ class FlatEvtVtxGenerator : public BaseEvtVtxGenerator { /// set max in Z in cm void maxZ(double m = 0); -private: - /** Copy constructor */ - FlatEvtVtxGenerator(const FlatEvtVtxGenerator& p) = delete; - /** Copy assignment operator */ - FlatEvtVtxGenerator& operator=(const FlatEvtVtxGenerator& rhs) = delete; - private: double fMinX, fMinY, fMinZ, fMinT; double fMaxX, fMaxY, fMaxZ, fMaxT; diff --git a/IOMC/EventVertexGenerators/interface/GaussEvtVtxGenerator.h b/IOMC/EventVertexGenerators/interface/GaussEvtVtxGenerator.h index 3e5fb645096d4..b2c18584f7006 100644 --- a/IOMC/EventVertexGenerators/interface/GaussEvtVtxGenerator.h +++ b/IOMC/EventVertexGenerators/interface/GaussEvtVtxGenerator.h @@ -16,6 +16,10 @@ namespace CLHEP { class GaussEvtVtxGenerator : public BaseEvtVtxGenerator { public: GaussEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + GaussEvtVtxGenerator(const GaussEvtVtxGenerator& p) = delete; + /** Copy assignment operator */ + GaussEvtVtxGenerator& operator=(const GaussEvtVtxGenerator& rhs) = delete; ~GaussEvtVtxGenerator() override; /// return a new event vertex @@ -38,12 +42,6 @@ class GaussEvtVtxGenerator : public BaseEvtVtxGenerator { /// set mean in Z in cm void meanZ(double m = 0) { fMeanZ = m; } -private: - /** Copy constructor */ - GaussEvtVtxGenerator(const GaussEvtVtxGenerator& p) = delete; - /** Copy assignment operator */ - GaussEvtVtxGenerator& operator=(const GaussEvtVtxGenerator& rhs) = delete; - private: double fSigmaX, fSigmaY, fSigmaZ; double fMeanX, fMeanY, fMeanZ; diff --git a/IOMC/EventVertexGenerators/interface/HLLHCEvtVtxGenerator.h b/IOMC/EventVertexGenerators/interface/HLLHCEvtVtxGenerator.h index cb3a37eae050c..40f2de9ce5ed0 100644 --- a/IOMC/EventVertexGenerators/interface/HLLHCEvtVtxGenerator.h +++ b/IOMC/EventVertexGenerators/interface/HLLHCEvtVtxGenerator.h @@ -27,6 +27,12 @@ class HLLHCEvtVtxGenerator : public BaseEvtVtxGenerator { public: HLLHCEvtVtxGenerator(const edm::ParameterSet& p); + /** Copy constructor */ + HLLHCEvtVtxGenerator(const HLLHCEvtVtxGenerator& p) = delete; + + /** Copy assignment operator */ + HLLHCEvtVtxGenerator& operator=(const HLLHCEvtVtxGenerator& rhs) = delete; + ~HLLHCEvtVtxGenerator() override; static void fillDescriptions(edm::ConfigurationDescriptions& descriptions); @@ -37,12 +43,6 @@ class HLLHCEvtVtxGenerator : public BaseEvtVtxGenerator { TMatrixD const* GetInvLorentzBoost() const override { return nullptr; }; private: - /** Copy constructor */ - HLLHCEvtVtxGenerator(const HLLHCEvtVtxGenerator& p) = delete; - - /** Copy assignment operator */ - HLLHCEvtVtxGenerator& operator=(const HLLHCEvtVtxGenerator& rhs) = delete; - //spatial and time offset for mean collision const double fMeanX, fMeanY, fMeanZ, fTimeOffset; diff --git a/IOPool/Output/src/RootOutputTree.cc b/IOPool/Output/src/RootOutputTree.cc index c86b9712ed2d2..e97b6135b08f6 100644 --- a/IOPool/Output/src/RootOutputTree.cc +++ b/IOPool/Output/src/RootOutputTree.cc @@ -41,12 +41,12 @@ namespace edm { class DuplicateTreeSentry { public: DuplicateTreeSentry(TTree* tree) : tree_(tree) { dup(); } + DuplicateTreeSentry(DuplicateTreeSentry const&) = delete; // Disallow copying and moving + DuplicateTreeSentry& operator=(DuplicateTreeSentry const&) = delete; TTree* tree() const { return mytree_ ? mytree_.get() : tree_; } private: - DuplicateTreeSentry(DuplicateTreeSentry const&) = delete; // Disallow copying and moving - DuplicateTreeSentry& operator=(DuplicateTreeSentry const&) = delete; struct CloseBeforeDelete { void operator()(TFile* iFile) const { if (iFile) { From 77f04ba5347625fc93d6bc36152f0ee6243c280e Mon Sep 17 00:00:00 2001 From: Shahzad Malik Muzaffar Date: Thu, 29 Jul 2021 12:55:08 +0200 Subject: [PATCH 2/2] code-format --- CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h | 2 +- EventFilter/GctRawToDigi/src/GctUnpackCollections.h | 2 +- EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h | 1 - EventFilter/RctRawToDigi/src/RctUnpackCollections.h | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h b/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h index bbae10c425321..586f30bb48c08 100644 --- a/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h +++ b/CaloOnlineTools/HcalOnlineDb/interface/XMLLUTLoader.h @@ -50,7 +50,7 @@ class XMLLUTLoader : public XMLDOMBlock { XMLLUTLoader(); XMLLUTLoader(XMLProcessor::loaderBaseConfig* config, std::string templateBase = "HCAL_TRIG_PRIM_LOOKUP_TABLE.XMLloader.template"); - XMLLUTLoader(const XMLLUTLoader&) = delete; // stop default + XMLLUTLoader(const XMLLUTLoader&) = delete; // stop default const XMLLUTLoader& operator=(const XMLLUTLoader&) = delete; // stop default ~XMLLUTLoader() override; diff --git a/EventFilter/GctRawToDigi/src/GctUnpackCollections.h b/EventFilter/GctRawToDigi/src/GctUnpackCollections.h index f980f757dc31a..46d0278998c18 100644 --- a/EventFilter/GctRawToDigi/src/GctUnpackCollections.h +++ b/EventFilter/GctRawToDigi/src/GctUnpackCollections.h @@ -24,7 +24,7 @@ class GctUnpackCollections { GctUnpackCollections(edm::Event& event); /// deliberately not implemented! - GctUnpackCollections(const GctUnpackCollections&) = delete; ///< Copy ctor + GctUnpackCollections(const GctUnpackCollections&) = delete; ///< Copy ctor GctUnpackCollections& operator=(const GctUnpackCollections&) = delete; ///< Assignment op /// Destructor - the last action of this object is to put the gct collections into the event provided on construction. diff --git a/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h b/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h index 1b8a5027d817e..ef88ae3f42e68 100644 --- a/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h +++ b/EventFilter/L1TXRawToDigi/interface/UCTAMCRawData.h @@ -9,7 +9,6 @@ class UCTAMCRawData { UCTAMCRawData(const UCTAMCRawData &) = delete; const UCTAMCRawData &operator=(const UCTAMCRawData &i) = delete; - virtual ~UCTAMCRawData() { ; } // Access functions for convenience diff --git a/EventFilter/RctRawToDigi/src/RctUnpackCollections.h b/EventFilter/RctRawToDigi/src/RctUnpackCollections.h index 169d131225b08..db93e4085417f 100644 --- a/EventFilter/RctRawToDigi/src/RctUnpackCollections.h +++ b/EventFilter/RctRawToDigi/src/RctUnpackCollections.h @@ -21,7 +21,7 @@ class RctUnpackCollections { RctUnpackCollections(edm::Event& event); /// deliberately not implemented! - RctUnpackCollections(const RctUnpackCollections&) = delete; ///< Copy ctor + RctUnpackCollections(const RctUnpackCollections&) = delete; ///< Copy ctor RctUnpackCollections& operator=(const RctUnpackCollections&) = delete; ///< Assignment op /// Destructor - the last action of this object is to put the rct collections into the event provided on construction.