diff --git a/.clang-tidy b/.clang-tidy index b1cc9d2d7a691..39177787cbeb9 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -9,6 +9,7 @@ Checks: -*, ,modernize-use-equals-delete, ,modernize-use-nullptr, ,modernize-use-override, + ,performance-inefficient-algorithm, ,performance-unnecessary-copy-initialization, ,readability-container-size-empty, ,readability-redundant-string-cstr, diff --git a/CondFormats/HcalObjects/src/HBHEDarkening.cc b/CondFormats/HcalObjects/src/HBHEDarkening.cc index ccc9a801c71ee..0f2fca22da1f1 100644 --- a/CondFormats/HcalObjects/src/HBHEDarkening.cc +++ b/CondFormats/HcalObjects/src/HBHEDarkening.cc @@ -105,7 +105,7 @@ float HBHEDarkening::degradation(float intlumi, int ieta, int lay) const { //accumulate degradation over years float response = 1.0; std::string yearForLumi = getYearForLumi(intlumi); - assert(yearForLumi.size()); + assert(!yearForLumi.empty()); for (const auto& year : years_) { response *= degradationYear(year, intlumi, ieta, lay); diff --git a/Fireworks/Core/src/FWDialogBuilder.cc b/Fireworks/Core/src/FWDialogBuilder.cc index d835b3030303d..95bb9157e3b7e 100644 --- a/Fireworks/Core/src/FWDialogBuilder.cc +++ b/Fireworks/Core/src/FWDialogBuilder.cc @@ -51,7 +51,7 @@ FWLayoutBuilder &FWLayoutBuilder::indent(int left /*= 2*/, int right /* = -1*/) /** Return the last vertical frame, for more control on the layout. */ TGVerticalFrame *FWLayoutBuilder::verticalFrame(void) { - assert(m_framesStack.size()); + assert(!m_framesStack.empty()); return m_framesStack.back(); }