Fix UB by settting firstStep in AnnealingGhostTrackFitter

David Abdurachmanov · David Abdurachmanov · commit c5bc57387bdc · 2015-10-12T17:16:45.000+02:00
Resolved undefined behavior triggered in `AnnealingGhostTrackFitter`:

    RecoVertex/GhostTrackFitter/interface/AnnealingGhostTrackFitter.h:22:27:
    runtime error: load of value 105, which is not a valid value for type
    'bool'

The class has user provided ctor, but `firstStep` is not explicitly
initialized thus it's default-initialized to indeterminate value.

Signed-off-by: David Abdurachmanov &lt;David.Abdurachmanov@cern.ch&gt;
diff --git a/RecoVertex/GhostTrackFitter/src/AnnealingGhostTrackFitter.cc b/RecoVertex/GhostTrackFitter/src/AnnealingGhostTrackFitter.cc
@@ -9,7 +9,7 @@
 
 using namespace reco;
 
-AnnealingGhostTrackFitter::AnnealingGhostTrackFitter()
+AnnealingGhostTrackFitter::AnnealingGhostTrackFitter() : firstStep(true)
 {
 	annealing.reset(new GeometricAnnealing(3.0, 64.0, 0.25));
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`using namespace reco;`
`11`	`11`
`12`		`-AnnealingGhostTrackFitter::AnnealingGhostTrackFitter()`
	`12`	`+AnnealingGhostTrackFitter::AnnealingGhostTrackFitter() : firstStep(true)`
`13`	`13`	`{`
`14`	`14`	`annealing.reset(new GeometricAnnealing(3.0, 64.0, 0.25));`
`15`	`15`	`}`