Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older lxml versions have no predictable element attribute order #115

Closed
dagwieers opened this issue Jun 7, 2017 · 1 comment · Fixed by ansible/ansible#25323
Closed
Labels

Comments

@dagwieers
Copy link
Collaborator

dagwieers commented Jun 7, 2017

So it appears that the tests in this module expect a predictable element attribute order, which is only added since lxml v3.0alpha1. For example CentOS-6 natively ships with lxml v2.2.3.

For the effort of upstreaming this module, we opted to filter out these tests when the lxml version is not greater or equal to 3. The module still works fine, we simply are not comparing as smart as we should.

@dagwieers
Copy link
Collaborator Author

dagwieers commented Aug 9, 2017

This is now fixed in the upstreamed module. (It now gives a proper error)

@dagwieers dagwieers added the bug label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant