Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path entry for <git>/cmd instead of <git>/bin? #853

Closed
jankatins opened this issue Feb 23, 2016 · 2 comments
Closed

path entry for <git>/cmd instead of <git>/bin? #853

jankatins opened this issue Feb 23, 2016 · 2 comments

Comments

@jankatins
Copy link
Contributor

The current git installer adds C:\Program Files(x86)\Git\cmd (and not C:\Program Files(x86)\Git\bin) to the path. IMO we should also change our path entry. /cmd would also make the start-ssh-agent.cmd script available in bash, which could then added (inactive...) to the default config/user-profile.sh.

On the other hand, /bin contains bash.exe, which might be good to have. So maybe add both?

Another thing I'm not a real an of is that C:\Program Files\Git\usr\bin is added at the start of the path, so things like windows find are shadowed by the git equivalent:

λ where find
C:\Program Files\Git\usr\bin\find.exe
C:\Windows\System32\find.exe
c:\Rtools\bin\find.exe

I'm not sure if that was intentional (fc85915).

So, IMO the path which is set if git is found should be:

set "PATH=%GIT_INSTALL_ROOT%\cmd;%PATH%;%GIT_INSTALL_ROOT%\bin;%GIT_INSTALL_ROOT%\usr\bin;%GIT_INSTALL_ROOT%\usr\share\vim\vim74;"

[Or remove the \usr\bin entry and add that as an example to the generated user-startup.cmd]

And the same in the bash/ps startup scripts...

This was referenced Mar 2, 2016
@jankatins
Copy link
Contributor Author

Ok, I implemented that in #865

-> Unix commands are always added to the end of the PATH.

@Stanzilla
Copy link
Member

Closed in favor of #865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants