-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix forwardRef warning in split panel #2884
Conversation
@@ -21,20 +21,3 @@ export function createWidgetizedComponent<Component extends FunctionComponent<an | |||
}) as Component; | |||
}; | |||
} | |||
|
|||
export function createWidgetizedForwardRef< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the last use of this function. Remove it, because we do not support forward-ref-as-widgets
475165d
to
6e82535
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
- Coverage 96.20% 96.20% -0.01%
==========================================
Files 761 761
Lines 21445 21434 -11
Branches 7340 7326 -14
==========================================
- Hits 20631 20620 -11
Misses 761 761
Partials 53 53 ☔ View full report in Codecov by Sentry. |
6e82535
to
1b2f22b
Compare
1b2f22b
to
53cf6c5
Compare
Description
Replace forwardRef with a plain component to fix this React warning:
Related links, issue #, if available: n/a
How has this been tested?
Locally, because it is only a warning
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.