Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Skip Releases #13

Closed
korenyoni opened this issue Jul 2, 2021 · 2 comments · Fixed by #18
Closed

Add Ability to Skip Releases #13

korenyoni opened this issue Jul 2, 2021 · 2 comments · Fixed by #18

Comments

@korenyoni
Copy link
Member

korenyoni commented Jul 2, 2021

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

The exclude-labels option should be included by default in auto-release.yaml

Expected Behavior

When a PR is merged with a skip-release label, a release should not be made.

Use Case

If a PR does not add any functionality to the actual module, e.g. a README typo fix, then there should be a way to skip the release. Repos using this template should have this ability.

Describe Ideal Solution

At first I believed that simply setting exclude-labels in .github/auto-release.yaml will enable this. However that only skips the release from being drafted. A release will still be made because of the publish action input.

The actual solution probably involves detecting the labels in the PR and programatically setting publish based on that, within the auto-release GitHub Actions workflow.

Alternatives Considered

N/A

Additional Context

N/A

@korenyoni korenyoni changed the title Add exclude-labels option to auto-release.yaml Add Ability to Skip Releases Jul 2, 2021
@nitrocode
Copy link
Member

There is a no-release label you could use

@korenyoni
Copy link
Member Author

@nitrocode this is in build-harness but this template repo's workflows need to be updated.

Will make a PR to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants