Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Resource: cloudflare_firewall_rule and cloudflare_filter #25

Closed
jason-riddle opened this issue Jun 3, 2023 · 4 comments · Fixed by #43
Closed

Deprecated Resource: cloudflare_firewall_rule and cloudflare_filter #25

jason-riddle opened this issue Jun 3, 2023 · 4 comments · Fixed by #43
Labels
bug 🐛 An issue with the system

Comments

@jason-riddle
Copy link

jason-riddle commented Jun 3, 2023

Describe the Bug

The cloudposse/zone/cloudflare module makes use of resources cloudflare_firewall_rule and cloudflare_filter. Because of this, there are these deprecation messages.

`cloudflare_firewall_rule` resource is in a deprecation phase that will
│ last for one year (May 1st, 2024). During this time period, this
│ resource is still fully supported but you are strongly advised
│ to move to the `cloudflare_ruleset` resource. For more information, see
│ https://developers.cloudflare.com/waf/reference/migration-guides/firewall-rules-to-custom-rules/#relevant-changes-for-terraform-users.

and

`cloudflare_filter` resource is in a deprecation phase that will
│ last for one year (May 1st, 2024). During this time period, this
│ resource is still fully supported but you are strongly advised
│ to move to the `cloudflare_ruleset` resource. For more information, see
│ https://developers.cloudflare.com/waf/reference/migration-guides/firewall-rules-to-custom-rules/#relevant-changes-for-terraform-users.

Expected Behavior

Should be able to use the module without any deprecation messages.

Steps to Reproduce

Create main.tf and add the following

module "cloudflare_zone" {
  source  = "cloudposse/zone/cloudflare"
  version = "0.5.0"
  enabled = true

  account_id   = "<your_account_id>"
  zone         = "<your_zone>"
  zone_enabled = false

  records = [
    # Google Site Verification
    {
      name    = "example.com"
      value   = "google-site-verification=123"
      type    = "TXT"
      ttl     = 1
      proxied = false
    }
  ]
}

Running apply will produce the deprecation messages.

Screenshots

No response

Environment

  • OS: OSX
  • OS Version: 12.6.3
  • Module Version: 0.5.0
  • Terraform Version: 1.4.5

Additional Context

@jason-riddle jason-riddle added the bug 🐛 An issue with the system label Jun 3, 2023
@bcdady
Copy link
Contributor

bcdady commented Feb 19, 2024

I just ran into this same error. Bump.

1 similar comment
@ramki-certn
Copy link

I just ran into this same error. Bump.

@purduemike
Copy link

Any fix available for this? Ran into this today.

@osterman
Copy link
Member

Any pull requests welcome. We don't have any active customer engagements that could sponsor this work. Tag us in #pr-reviews on SweetOps to prioritize review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants