Address issue with maxReceiveCount key in subscription redrive policy

[userhas404d]

what

• Address issue with maxReceiveCount key in subscription redrive policy
• Updates provided example with multiple subscriptions

why

• I'd like to utilize this module for existing infrastructure that requires an sns topic with multiple subscriptions

maxReceiveCount when provided

Error: error setting SNS Topic Subscription (arn:aws:sns:us-west-2::eg-test-sns.fifo:310f9002-0630-42dc-ba81-1ce9521840d3) attribute (RedrivePolicy): InvalidParameter: Invalid parameter: RedrivePolicy: invalid JSON. Attribute maxReceiveCount is unknown.

references

• Closes Attribute maxReceiveCount is unknown #48
• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sqs_queue
• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic_subscription#redrive_policy

[nitrocode]

See comments

[nitrocode]

This is simpler.

Suggested change

	var.redrive_policy_max_receiver_count != null ? {
	deadLetterTargetArn = join("", aws_sqs_queue.dead_letter_queue.*.arn)
	maxReceiveCount = var.redrive_policy_max_receiver_count
	} : {
	deadLetterTargetArn = join("", aws_sqs_queue.dead_letter_queue.*.arn)
	deadLetterTargetArn = join("", aws_sqs_queue.dead_letter_queue.*.arn)
	maxReceiveCount = var.redrive_policy_max_receiver_count

[userhas404d]

using anything other than what I have here still raises this error:

Error: error creating SNS Topic Subscription: InvalidParameter: Invalid parameter: Attributes Reason: RedrivePolicy: invalid JSON. Attribute maxReceiveCount is unknown.

[nitrocode]

Looks like this redrive policy may need to be added directly to the sqs queue

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sqs_queue

Then the redrive policy for sns topic subscription may only support the deadLetterTargetArn

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic_subscription#redrive_policy

[userhas404d]

this lines up with these findings:

The only reference I could find for it in the AWS api docs was here, its suspiciously not called out in the boto3 documentation for SNS topic subscriptions nor in the api docs for SNS Subscribe

So are we back to removing the redrive_policy_max_receiver_count input var? And I suppose simplifying the redrive_policy input in aws_sns_topic_subscription.this is in order as well?

[nitrocode]

I don't think we need to remove redrive_policy_max_receiver_count. I think we need to add the appropriate redrive_policy to the appropriate resource.

aws_sqs_queue has both deadLetterTargetArn and maxReceiveCount

aws_sns_topic_subscription has only deadLetterTargetArn

[userhas404d]

aws_sqs_queue has both deadLetterTargetArn and maxReceiveCount

right, but the only sqs queue we're defining in the root module is the dlq - are you saying you want to include a redrive policy on it? That seems a little redundant, no?

[userhas404d]

went ahead and removed input_redrive_policy_max_receiver_count and by extension the maxRecieveCount key from the aws_sns_topic_subscription redrive policy, if you want me add it to the dlq please lmk

[nitrocode]

Please merge from the default branch in order for passing tests

[hans-d]

/terratest

[nitrocode]

Hmm, not sure why this was closed, but the PR did get stale.

Maybe we just remove this argument as another person ran into the same issue.

PR #89 will supersede this PR 56