Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notice about redrive_policy from readme #47

Conversation

shinenelson
Copy link

what

redrive_plicy was added in e932f7e ( tag:v0.20.0 ), but this notice was missed to be removed.

why

the notice could be misleading to users who visit the module's readme and see the notice even though the feature already exists in the module.

references

@shinenelson shinenelson requested review from a team as code owners December 19, 2021 17:58
redrive_plicy was added in e932f7e ( tag:v0.20.0 ), but this notice was
missed to be removed.
@shinenelson shinenelson force-pushed the readme/remove-redrive-policy-notice branch from f77c394 to 31ed276 Compare December 19, 2021 18:15
@khdevel
Copy link

khdevel commented Apr 28, 2022

@shinenelson I think that you should also include usage of the redrive_policy and redrive_allow_policy variables in the sqs_queue resource.

@acorncom
Copy link

Is it possible to get this change in? Hard to tell the state of this module when reading over the Readme ... :-)

@Gowiem Gowiem requested review from Gowiem and removed request for Makeshift and dylanbannon April 17, 2023 17:02
@Gowiem
Copy link
Member

Gowiem commented Apr 17, 2023

@shinenelson thanks for this small docs update, it's much appreciated! We'll work to get this merged.

Could I also bug you to open an issue so we have a means by tracking the addition of redrive_policy? That way maybe a contributor who needs it will see that and add it in a future PR?

@Gowiem
Copy link
Member

Gowiem commented Apr 17, 2023

/test all

@Gowiem
Copy link
Member

Gowiem commented Apr 17, 2023

Ah we release a v0.20 of this module and it added support for redrive_policy. Nevermind on creating that issue @shinenelson!

We have issues with the README here. I am going to fix via a separate PR and we'll get this change in. Will close this via another PR.

@Gowiem
Copy link
Member

Gowiem commented Apr 18, 2023

Thanks for the help in pushing this forward @shinenelson @khdevel and @acorncom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants