fix: apply db_port to actual instance

[ekristen]

what

Makes the db_port effective. Currently it only modifies the security group, not the actual RDS port.

why

The current variable is broken, it modifies the security group but not the underlying cluster, therefore it's actually renders the variable ineffective as is. In fact if you do not set it do the default for the database type, the use of the module will not work.

references

• Resolves db_port not working as expected #120

[Gowiem]

/test all

[Gowiem]

It's amazing to me that we haven't caught this until now... Guess that goes to show how many folks just use the default port in 99% of cases.

Thanks for the quick fix @ekristen!

[ekristen]

Looks like we had some errors on terratest, odd that it says that encryption is always enabled on Serverless. I'm actually using Serverless v2 right now that that's not the case, you can have un-encrypted clusters.

[Gowiem]

@ekristen I'm sorry about this, it's a PITA, but can you do me a favor and add storage_encrypted = true to the complete example here: https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/examples/complete/main.tf#L28

I'm not sure why this is failing now... but let's see if we can appease it and get this very reasonable and important fix in. Appreciate it!

[ekristen]

all good @Gowiem commit sent, lets see if we get tests to pass.

[Gowiem]

/test all

[hans-d]

closing

[echibuogwu]

Not sure why this was closed, I created a new PR here #222