Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform registry version 0.6.7 does not match GitHub tag 0.6.7 #48

Closed
damonmcminn opened this issue Jun 30, 2023 · 2 comments
Closed
Labels
bug 🐛 An issue with the system

Comments

@damonmcminn
Copy link

Describe the Bug

The generated policy of terraform version 0.6.7 is absent of c17b4b6 which leads me to conclude that the Terraform registry version 0.6.7 is somehow actually 0.6.6?

Expected Behavior

Terraform registry version 0.6.7 matches GitHub tag 0.6.7

Steps to Reproduce

terraform init with:

module "cloudwatch-logs" {
  source  = "cloudposse/cloudwatch-logs/aws"
  version = "0.6.7"
}

Then view data "aws_iam_policy_document" "log_agent" block in .infrastructure/.terraform/modules/cloudwatch_logs/iam.tf

Screenshots

No response

Environment

0.6.7 with:
Terraform v1.5.2
on linux_amd64

Additional Context

No response

@damonmcminn damonmcminn added the bug 🐛 An issue with the system label Jun 30, 2023
@damonmcminn
Copy link
Author

Please forgive me, I'm an idiot: The version does indeed match, however I was incorrectly expecting the following block to have the fix:

  statement {
    actions = [
      "logs:PutLogEvents",
    ]

    resources = [
      join("", aws_cloudwatch_log_group.default.*.arn),
    ]
  }

https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/0.6.7/iam.tf#L47

But it does not. It doesn't work the way I expect, but seeing as I can use addtional_permissions to workaround it, I will close this bug.

@damonmcminn
Copy link
Author

Stale PR that fixes source of my confusion: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant